From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id A7D5B138E66 for ; Mon, 24 Feb 2014 18:57:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3063AE0ADB; Mon, 24 Feb 2014 18:57:04 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 98624E0ADA for ; Mon, 24 Feb 2014 18:57:03 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id B532533FA97 for ; Mon, 24 Feb 2014 18:57:02 +0000 (UTC) Date: Mon, 24 Feb 2014 10:56:59 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] Add a test case for --newuse, --changed-use, and --binpkg-respect-use. Message-ID: <20140224105659.37ffe539.dolsen@gentoo.org> In-Reply-To: <1393265666-8837-1-git-send-email-davidjames@google.com> References: <1393265666-8837-1-git-send-email-davidjames@google.com> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 0188d00f-f297-49fb-a0ef-4a3ff0eea030 X-Archives-Hash: f79d5ec17f3c289597c0f2437fe57851 On Mon, 24 Feb 2014 10:14:26 -0800 David James wrote: > Change-Id: I201e468c6e7cda6aa961371ad9ddc10cfab04bc7 > --- > pym/portage/tests/resolver/test_useflags.py | 78 +++++++++++++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 pym/portage/tests/resolver/test_useflags.py > > Was there a difference in this posting to the one last Thursday? If not a simple bump reminder was all that should have been done. If it is different, they you should have created the patch with the -v 2 format-patch option. And summarized the changes. Sebastian I believe, has had the most experience with the tests, so I will leave the review up to him, Mike. -- Brian Dolbec