From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id BB1A3138247 for ; Wed, 22 Jan 2014 05:34:00 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 34D8BE0FBB; Wed, 22 Jan 2014 05:34:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 85FF4E0F68 for ; Wed, 22 Jan 2014 05:33:59 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 7FEF333F929; Wed, 22 Jan 2014 05:33:58 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring Date: Wed, 22 Jan 2014 00:34:02 -0500 User-Agent: KMail/1.13.7 (Linux/3.13.0; KDE/4.6.5; x86_64; ; ) Cc: Alec Warner References: <52DC55A0.9020300@plaimi.net> In-Reply-To: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1546758.QqFMhdhKiP"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201401220034.03209.vapier@gentoo.org> X-Archives-Salt: 80369669-6e5d-4457-953b-b89b0f4d39e9 X-Archives-Hash: 7c4a0ea1020544e7b54e51b1861806cc --nextPart1546758.QqFMhdhKiP Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday 19 January 2014 17:46:36 Alec Warner wrote: > On Sun, Jan 19, 2014 at 2:45 PM, Alexander Berntsen wrote: > > On 19/01/14 22:22, Sebastian Luther wrote: > > > The usual doc string style used in portage is: > > >=20 > > > """ text """ > > >=20 > > > Please use that for new functions. Also make sure you don't use > > > spaces to indent the last """. > >=20 > > As mentioned by Mike in another thread, we should use PEP 257[0]. I > > will convert old code to conform to this... sometime... soon... (I > > promise!) > >=20 > > So if new patches could just do that right away, that would be neat. >=20 > Does pylint or pyflakes point out if you mess it up? >=20 > Automation for the win. the good news is that i wrote a pylintrc module for Chromium OS to enforce= =20 docstring style. the bad news is that it doesn't work with pyflakes. https://chromium.googlesource.com/chromiumos/chromite/+/master/cros/command= s/lint.py what we did there was just merge it and then have people fix things up as t= hey=20 went rather than try to clean it all up first. =2Dmike --nextPart1546758.QqFMhdhKiP Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJS31hLAAoJEEFjO5/oN/WBCWgQAIl8AWo9XxFALvXbr3rB+F8P yCAlIoUcTYktHIFf+syiU58dfuTtoOd5nJEkGZSRj3P3md2vKzvrZ3ZMf7VkxK6N E4nyGP58iv9D2NN9WM463KYAhrChQL7Ilxfwnqv5GHk+GxZEjyTqKboPom55FCy0 kIO1zgrS6K2gvzsNPJhpmqkMcgSIzbEO2nykuWQ8fn+NUkaA0tfCIc+24Th9ksQ7 KypoeZOUN+4sv9u6Nlmkr3A6cCOhXyBMxd87JZ1knq7w9kF5riuLNWnpi3aMJ7YO 1UGqncidcrCxiU4IL81UcA6/1XKvanToy5HhoO6WbpF2aFbD5i7hmsA+LcTKBQfX GI9jb0ms2vn+moBBMUmggohMVsOfYseSbPc63qnKLI3IlcZvErFeZaF6yomeSk+l iyTfUmM5bciJtjfr686egt2VIOjW1X2VCKM04ia+MTbBoDWIZateMh4ocSamA34x df1ZLKUBbaQEuakAjMWBFlF2HvgtK9upmaWFxM9AAEgY3l4IPSzHdwaMdylHFcN8 0fotvQxO9SMIEEykxLiPE9Va+abuzW+36h6cXn7gboMTI1Srwb9KVC9Xef4D5DlO CyyKpuCRk+/5p8cqkxFMHwiIJbGj8b8DZZL0C6QzIrYHaDDslUsf4LCmpc9qSlj9 xeVu1iQn5k+rbs4LMyYg =voxM -----END PGP SIGNATURE----- --nextPart1546758.QqFMhdhKiP--