From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 22050138247 for ; Tue, 21 Jan 2014 15:33:41 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 55DA6E0BE6; Tue, 21 Jan 2014 15:33:39 +0000 (UTC) Received: from albert.telenet-ops.be (albert.telenet-ops.be [195.130.137.90]) by pigeon.gentoo.org (Postfix) with ESMTP id 9F966E0BC0 for ; Tue, 21 Jan 2014 15:33:38 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by albert.telenet-ops.be with bizsmtp id GfZd1n0032khLEN06fZdNP; Tue, 21 Jan 2014 16:33:37 +0100 Date: Tue, 21 Jan 2014 16:32:33 +0100 From: Tom Wijsman To: antarus@gentoo.org Cc: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 1/3 v2] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909). Message-ID: <20140121163233.722e8ee5@TOMWIJ-GENTOO> In-Reply-To: References: <1389830840-25848-2-git-send-email-tomwij@gentoo.org> <1389999837-16516-1-git-send-email-tomwij@gentoo.org> <201401190438.32666.vapier@gentoo.org> <20140120032348.429ed4d3@TOMWIJ-GENTOO> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.22; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/b0uzjeG.JOyoz2vfF5WMqIO"; protocol="application/pgp-signature" X-Archives-Salt: bb270623-8935-4099-ac5c-186b5874e7d1 X-Archives-Hash: 35db05fcb942eecc29ac9f16fb85b4da --Sig_/b0uzjeG.JOyoz2vfF5WMqIO Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 19 Jan 2014 18:43:46 -0800 Alec Warner wrote: > It is certainly weird (as we discussed on IRC.) I've never seen > anyone do it in any codebase I liked. My backlog was limited so I didn't catch that discussion, feel free to share the log; I've since increased it. There's a lot more talk than my defaults on IRC (as well as here on the mailing list). :) On a side note, "I liked" seems a too subjective way to review patches. > One of the problems is that it isn't immutable, so that earlier > callers can mess with later callers. That is not possible in vapier's > proposal, as the attributes are hidden in the function code and are > not visible to callers. True, but do you have a better suggestion? (Not the one below) =46rom a quick lookup Python seems to not really provide a clean immutable solution here; one option would be to use a frozenset, but then one has to make classes to put into that (which are still mutable). That is a misuse for what could just be a dictionary. > > move it into the class definition. > > > def getNonSystemArchiveDepends(fetchlist, eapi): > > > ... > > > > > > ARCHIVERS =3D { > > > ... > > > } > > > > That makes it a non-static function variable? This is a regression. >=20 > I guess I am not seeing why it must be a static function variable. > Can you explain? Because you would call re.compile for each time that function is called; while the most recent compiled versions of re.compile are cached, I still do not see a reason for this variable not to be static. > For the colon's in dicts thing: >=20 > http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Whitespace Okay, I will follow those guidelines. > The @system set in gentoo will ensure these are installed. You can compare @system against the PMS and you will note that entries are missing in @system; the @system set only covers the most popular ones, the rest is left up to the maintainer to add to the ebuild. Thus this enumerates all of them; as the @system set can change in the future, we need to make the code future proof hence the @system check. It is possible for such atom to get removed from @system later. > understand the wording of PMS (as the dependencies should be > expressed somewhere) but in general we prefer to do that in @system. > For the same reason all packages do not depend on glibc, or the > compiler, or anything else. Things that are in @system are not complained about by this code: if format not in system_set_atoms: --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/b0uzjeG.JOyoz2vfF5WMqIO Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJS3pMRAAoJEJWyH81tNOV9pLoH/Al41k2j5/Z06P23o78GrYDt hsmVhZt+mgBd0I9hwfUi4KjmywlmKsjWK7+vlJYf1ssG3AuucUuCJIh7z1+G3lzE FciE/U+zcvNiuQsfyDvduyjiZ2TCaNEsImq9snkB1QCaErCVZEjUjnz82vu0YjJ/ C/RLaSwL6Pa0OYvz2oEMuipzZZtPY2yWLL6Ae/6h+OnVKtkk0N2NRkIMPxttvGEa VGBSg4xx4lwB/+UunuxcI3Ob2VvtqoG1GCpwfgDFMIbaSKNBkjxOY0Se0h4mmyE+ yDmg1eGpIV2pU53INJUc3El9tUp4OnVM8nYxzCdEpTlWSzTkDJia9I9bEhXIw1U= =fHb/ -----END PGP SIGNATURE----- --Sig_/b0uzjeG.JOyoz2vfF5WMqIO--