Re: [gentoo-portage-dev] [PATCH v4] Test for read-only filesystems, bail out during preinst if there are any which will be written to and display a useful error message. Fixes bug 378869.

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 646 bytes --]

On Monday 20 January 2014 19:50:54 Chris Reffett wrote:
> +		# Check for read-only filesystems

please use full sentences.  that means putting a period at the end.  this 
applies to many additions in this patch.

> +	try:
> +		with io.open("/proc/mounts", mode='r', 
encoding=_encodings['content'],
> +			errors='replace') as f:
> +				roregex = re.compile(r'(\A|,)ro(\Z|,)')
> +				for line in f:
> +					if roregex.search(line.split(" ")[3].strip()) is not 
None:
> +						romount = line.split(" ")[1].strip()
> +						ro_filesystems.add(romount)

pretty sure the body of this with block is indented one too many times
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]