From: Tom Wijsman <TomWij@gentoo.org>
To: wking@tremily.us
Cc: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH 2/3] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size
Date: Mon, 20 Jan 2014 03:26:46 +0100 [thread overview]
Message-ID: <20140120032646.30e06b58@TOMWIJ-GENTOO> (raw)
In-Reply-To: <20140120020123.GZ29063@odin.tremily.us>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On Sun, 19 Jan 2014 18:01:23 -0800
"W. Trevor King" <wking@tremily.us> wrote:
> On Mon, Jan 20, 2014 at 02:41:41AM +0100, Tom Wijsman wrote:
> > There is some duplicate code here, I think the conditions can be
> > rewritten in such way that the duplicate code doesn't take place.
>
> Do you want a rewrite squashed into this commit, or as a follow-on
> commit after this one (which gets a test suite in v3)?
Sound more sane to do in a follow-up commit.
While writing this review I didn't note that you were just moving most
code, now you have ideas for further refactoring I guess. :)
--
With kind regards,
Tom Wijsman (TomWij)
Gentoo Developer
E-mail address : TomWij@gentoo.org
GPG Public Key : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2014-01-20 2:27 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 3:07 [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring W. Trevor King
2014-01-19 3:07 ` [gentoo-portage-dev] [PATCH 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries W. Trevor King
2014-01-20 1:26 ` Tom Wijsman
2014-01-20 1:56 ` W. Trevor King
2014-01-19 3:07 ` [gentoo-portage-dev] [PATCH 2/3] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size W. Trevor King
2014-01-20 1:41 ` Tom Wijsman
2014-01-20 2:01 ` W. Trevor King
2014-01-20 2:26 ` Tom Wijsman [this message]
2014-01-19 3:07 ` [gentoo-portage-dev] [PATCH 3/3] pym/portage/package/ebuild/fetch.py: Factor out _get_uris W. Trevor King
2014-01-19 21:36 ` Sebastian Luther
2014-01-19 21:43 ` W. Trevor King
2014-01-19 22:36 ` Alec Warner
2014-01-19 23:06 ` W. Trevor King
2014-01-19 23:31 ` W. Trevor King
2014-01-19 20:05 ` [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring Sebastian Luther
2014-01-19 20:58 ` W. Trevor King
2014-01-19 22:14 ` [gentoo-portage-dev] [PATCH v2 " W. Trevor King
2014-01-19 22:14 ` [gentoo-portage-dev] [PATCH v2 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries W. Trevor King
2014-01-19 22:44 ` Alec Warner
2014-01-19 22:45 ` Alec Warner
2014-01-19 22:51 ` W. Trevor King
2014-01-19 22:52 ` Alec Warner
2014-01-19 22:14 ` [gentoo-portage-dev] [PATCH v2 2/3] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size W. Trevor King
2014-01-19 22:14 ` [gentoo-portage-dev] [PATCH v2 3/3] pym/portage/package/ebuild/fetch.py: Factor out _get_uris W. Trevor King
2014-01-20 3:26 ` [gentoo-portage-dev] [PATCH v3 0/4] Initial fetch() refactoring W. Trevor King
2014-01-20 3:26 ` [gentoo-portage-dev] [PATCH v3 1/4] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries W. Trevor King
2014-01-20 3:26 ` [gentoo-portage-dev] [PATCH v3 2/4] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size W. Trevor King
2014-01-20 3:26 ` [gentoo-portage-dev] [PATCH v3 3/4] pym/portage/package/ebuild/fetch.py: Factor out _get_uris W. Trevor King
2014-01-21 2:57 ` [gentoo-portage-dev] " W. Trevor King
2014-01-20 3:26 ` [gentoo-portage-dev] [PATCH v3 4/4] pym/portage/package/ebuild/fetch.py: Flatten conditionals in _get_fetch_resume_size W. Trevor King
2014-01-22 5:35 ` [gentoo-portage-dev] [PATCH v3 0/4] Initial fetch() refactoring Mike Frysinger
2014-01-22 16:10 ` W. Trevor King
2014-01-22 19:00 ` Mike Frysinger
2014-01-27 4:00 ` [gentoo-portage-dev] " W. Trevor King
2014-01-19 21:22 ` [gentoo-portage-dev] [PATCH 0/3] " Sebastian Luther
2014-01-19 22:45 ` Alexander Berntsen
2014-01-19 22:46 ` Alec Warner
2014-01-19 22:50 ` Alexander Berntsen
2014-01-19 22:54 ` Alec Warner
2014-01-19 23:51 ` Alexander Berntsen
2014-01-19 23:53 ` Alec Warner
2014-01-19 23:11 ` W. Trevor King
2014-01-22 5:34 ` Mike Frysinger
2014-01-19 21:39 ` Sebastian Luther
2014-01-19 22:46 ` W. Trevor King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120032646.30e06b58@TOMWIJ-GENTOO \
--to=tomwij@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox