From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 2F531138247 for ; Mon, 20 Jan 2014 01:28:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 07B0FE0A9D; Mon, 20 Jan 2014 01:28:05 +0000 (UTC) Received: from andre.telenet-ops.be (andre.telenet-ops.be [195.130.132.53]) by pigeon.gentoo.org (Postfix) with ESMTP id 451D6E0A93 for ; Mon, 20 Jan 2014 01:28:04 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by andre.telenet-ops.be with bizsmtp id G1U31n0072khLEN011U3Gq; Mon, 20 Jan 2014 02:28:03 +0100 Date: Mon, 20 Jan 2014 02:26:59 +0100 From: Tom Wijsman To: wking@tremily.us Cc: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries Message-ID: <20140120022659.64bd2ac3@TOMWIJ-GENTOO> In-Reply-To: <26b08899dfaa958e93339ba9d33e5bf36f20a914.1390099978.git.wking@tremily.us> References: <26b08899dfaa958e93339ba9d33e5bf36f20a914.1390099978.git.wking@tremily.us> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.22; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/h_7dM_GtuqtUb_hqyWGJ0/s"; protocol="application/pgp-signature" X-Archives-Salt: ceacd311-5722-40bb-af13-2b92328f27ed X-Archives-Hash: dc737a9c51170febfb8d811ad36e3968 --Sig_/h_7dM_GtuqtUb_hqyWGJ0/s Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 18 Jan 2014 19:07:45 -0800 "W. Trevor King" wrote: > [...SNIP...] > + v =3D > int(settings.get("PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS", > + default)) > + except (ValueError, OverflowError): > + writemsg(_("!!! Variable > PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS" > + " contains non-integer value: '%s'\n") % \ > + > settings["PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS"], > + noiselevel=3D-1) > + writemsg(_("!!! Using > PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS " > + "default value: %s\n") % default, > + noiselevel=3D-1) > + v =3D default > + if v < 1: > + writemsg(_("!!! Variable > PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS" > + " contains value less than 1: '%s'\n") % v, > noiselevel=3D-1) > + writemsg(_("!!! Using > PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS " > [...SNIP...] The code screams PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS to me which makes it hard to read, I would suggest assigning it to a variable in advance as to not have to repeat it this often. Some code snippets for ideas: key =3D "PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS" v =3D int(settings.get(key), default) "!!! Variable %s contains non-integer value: '%s" % (key, ...) If needed, add a word to key to make the variable name slightly more meaningful; but avoid the full length if possible. eg. try_mirrors_key --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/h_7dM_GtuqtUb_hqyWGJ0/s Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJS3HtjAAoJEJWyH81tNOV9PfsH/38vYl+pPDR5taqUfu/3MImk 4NMzjmeqmCWWTWLzCr3Qp64IYcOtlbahq4PM9Ylw5YewAFVzE0kszwBY4NOh56RK piQYY7IMiQMSVsqwkC1WYfeWRZVx59ChZf0pSrsLA5+ESqhEaSbQ6XXzPzNJ/bqJ XRPo294VPpnIth/3iGbv8Pk92cDOfVQnDLcpVWXsHGpDpqqcvzHqOwsq357+0XK1 iQpRwsJ9rkgOWQZxxSnNubwYzl+gL+ghS0ZzcCpCTm2wgo18gFutZXk8B7WodeP9 8q/JBjzSyA7aHbRqwFFZ7hQoYJCR9WIGSYKeccTtUgBV9bJZqDPepKsEh7jfrYY= =Clvi -----END PGP SIGNATURE----- --Sig_/h_7dM_GtuqtUb_hqyWGJ0/s--