From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: Tom Wijsman <tomwij@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084).
Date: Sun, 19 Jan 2014 04:26:29 -0500 [thread overview]
Message-ID: <201401190426.29715.vapier@gentoo.org> (raw)
In-Reply-To: <1389830840-25848-4-git-send-email-tomwij@gentoo.org>
[-- Attachment #1: Type: Text/Plain, Size: 484 bytes --]
On Wednesday 15 January 2014 19:07:20 Tom Wijsman wrote:
> +class DeprecateG2CONF(LineCheck):
> + repoman_check_name = 'G2CONF.deprecated'
> + re = re.compile(r'.*G2CONF.*')
> +
> + def check(self, num, line):
> + """Run the check on line and return error if there is one"""
> + m = self.re.match(line)
use re.search instead of re.match so you can drop the redundant ".*".
further, i think you want to use word boundaries. so:
re = re.compile(r'\bG2CONF\b')
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-19 9:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 0:07 [gentoo-portage-dev] Repoman patches for bugs #205909, #245305 and #482084 Tom Wijsman
2014-01-16 0:07 ` [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909) Tom Wijsman
2014-01-16 1:44 ` Alec Warner
2014-01-16 21:18 ` Tom Wijsman
2014-01-16 21:23 ` Alexander Berntsen
2014-01-16 21:52 ` Tom Wijsman
2014-01-16 22:22 ` Alexander Berntsen
2014-01-16 23:02 ` Tom Wijsman
2014-01-17 6:14 ` Alec Warner
2014-01-17 23:35 ` Tom Wijsman
2014-01-17 0:33 ` Tom Wijsman
2014-01-16 7:03 ` Sebastian Luther
2014-01-16 21:40 ` Tom Wijsman
2014-01-17 8:35 ` Sebastian Luther
2014-01-17 23:00 ` Tom Wijsman
2014-01-18 6:49 ` Sebastian Luther
2014-01-17 8:28 ` Sebastian Luther
2014-01-17 16:40 ` Tom Wijsman
2014-01-17 23:03 ` [gentoo-portage-dev] [PATCH 1/3 v2] " Tom Wijsman
2014-01-19 9:38 ` Mike Frysinger
2014-01-20 2:23 ` Tom Wijsman
2014-01-20 2:43 ` Alec Warner
2014-01-21 15:32 ` Tom Wijsman
2014-01-16 0:07 ` [gentoo-portage-dev] [PATCH 2/3] Have repoman check that a package directory contains at least one ebuild (bug #245305) Tom Wijsman
2014-01-16 1:07 ` Jesus Rivero (Neurogeek)
2014-01-16 1:45 ` Alec Warner
2014-01-17 21:36 ` [gentoo-portage-dev] [PATCH 2/3 v2] " Tom Wijsman
2014-01-17 22:34 ` Jesus Rivero (Neurogeek)
2014-01-16 0:07 ` [gentoo-portage-dev] [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084) Tom Wijsman
2014-01-16 1:23 ` Jesus Rivero (Neurogeek)
2014-01-16 21:56 ` Tom Wijsman
2014-01-19 9:26 ` Mike Frysinger [this message]
2014-01-19 9:28 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401190426.29715.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=tomwij@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox