public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: Chris Reffett <creffett@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH v4] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 and if pkg_pretend is used in EAPI < 4. Fixes bug 379491.
Date: Sun, 19 Jan 2014 04:22:33 -0500	[thread overview]
Message-ID: <201401190422.33778.vapier@gentoo.org> (raw)
In-Reply-To: <1389821748-18454-1-git-send-email-creffett@gentoo.org>

[-- Attachment #1: Type: Text/Plain, Size: 157 bytes --]

Acked-by: Mike Frysinger <vapier@gentoo.org>

btw you should keep the patch summary short.  if it goes long, better to move 
it to the main body.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      parent reply	other threads:[~2014-01-19  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 21:35 [gentoo-portage-dev] [PATCH v4] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 and if pkg_pretend is used in EAPI < 4. Fixes bug 379491 Chris Reffett
2014-01-15 22:23 ` [gentoo-portage-dev] " Duncan
2014-01-15 22:54 ` [gentoo-portage-dev] " Tom Wijsman
2014-01-19  9:22 ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201401190422.33778.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=creffett@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox