Re: [gentoo-portage-dev] Signing off patches

["W. Trevor King" <wking@tremily.us>]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

On Sat, Jan 18, 2014 at 04:02:02PM +0100, Tom Wijsman wrote:
>  - Reviewed-by: Reviewed the patch thoroughly
> 
>    What extra information does this tell us? This can be seen on ML.

I think the idea is that you shouldn't need to refer to an external
resource like the mailing list to understand the idea behind the
patch, or the amount of review it received.  The body of the commit
message should summarize the consensus reached on the mailing list,
and these tags are basically standardized thank-you notes crediting
non-authors who were involved in that process.  They don't have to go
on every patch, but if you want to mention somebody:

  Reviewed-by: Random J Developer <random@developer.example.org>
  Reviewed-by: Other R Developer <other@developer.example.org>

at the end of the commit message is easier to write and read than:

  This patch was reviewed Random J Developer
  <random@developer.example.org> and Other R Developer
  <other@developer.example.org>.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]