From: Tom Wijsman <TomWij@gentoo.org>
To: SebastianLuther@gmx.de
Cc: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).
Date: Sat, 18 Jan 2014 00:00:06 +0100 [thread overview]
Message-ID: <20140118000006.43e9136e@TOMWIJ-GENTOO> (raw)
In-Reply-To: <52D8EB6E.9070504@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]
On Fri, 17 Jan 2014 09:35:58 +0100
Sebastian Luther <SebastianLuther@gmx.de> wrote:
> The "if entry not in system_set_atoms" line. You're using __contains__
> there (with the 'in'). You don't use the additional magic provided by
> PackageSet (which is a super class of PackagesSystemSet).
This is __contains__, which does what I want as far as I can see:
http://dev.gentoo.org/~zmedico/portage/doc/api/portage._sets.base-pysrc.html#PackageSet.__contains__
What is there wrong with this?
As for the additional magic, do you mean containsCPV? Looking at it:
http://dev.gentoo.org/~zmedico/portage/doc/api/portage._sets.base-pysrc.html#PackageSet.containsCPV
It seems more complex than is necessary, is there a benefit to this?
Sorry, I don't understand what is meant here; all the rest of your
feedback is clear and has been implemented and is in the v2 I plan to
send to the mailing list soon.
--
With kind regards,
Tom Wijsman (TomWij)
Gentoo Developer
E-mail address : TomWij@gentoo.org
GPG Public Key : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2014-01-17 23:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 0:07 [gentoo-portage-dev] Repoman patches for bugs #205909, #245305 and #482084 Tom Wijsman
2014-01-16 0:07 ` [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909) Tom Wijsman
2014-01-16 1:44 ` Alec Warner
2014-01-16 21:18 ` Tom Wijsman
2014-01-16 21:23 ` Alexander Berntsen
2014-01-16 21:52 ` Tom Wijsman
2014-01-16 22:22 ` Alexander Berntsen
2014-01-16 23:02 ` Tom Wijsman
2014-01-17 6:14 ` Alec Warner
2014-01-17 23:35 ` Tom Wijsman
2014-01-17 0:33 ` Tom Wijsman
2014-01-16 7:03 ` Sebastian Luther
2014-01-16 21:40 ` Tom Wijsman
2014-01-17 8:35 ` Sebastian Luther
2014-01-17 23:00 ` Tom Wijsman [this message]
2014-01-18 6:49 ` Sebastian Luther
2014-01-17 8:28 ` Sebastian Luther
2014-01-17 16:40 ` Tom Wijsman
2014-01-17 23:03 ` [gentoo-portage-dev] [PATCH 1/3 v2] " Tom Wijsman
2014-01-19 9:38 ` Mike Frysinger
2014-01-20 2:23 ` Tom Wijsman
2014-01-20 2:43 ` Alec Warner
2014-01-21 15:32 ` Tom Wijsman
2014-01-16 0:07 ` [gentoo-portage-dev] [PATCH 2/3] Have repoman check that a package directory contains at least one ebuild (bug #245305) Tom Wijsman
2014-01-16 1:07 ` Jesus Rivero (Neurogeek)
2014-01-16 1:45 ` Alec Warner
2014-01-17 21:36 ` [gentoo-portage-dev] [PATCH 2/3 v2] " Tom Wijsman
2014-01-17 22:34 ` Jesus Rivero (Neurogeek)
2014-01-16 0:07 ` [gentoo-portage-dev] [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084) Tom Wijsman
2014-01-16 1:23 ` Jesus Rivero (Neurogeek)
2014-01-16 21:56 ` Tom Wijsman
2014-01-19 9:26 ` Mike Frysinger
2014-01-19 9:28 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140118000006.43e9136e@TOMWIJ-GENTOO \
--to=tomwij@gentoo.org \
--cc=SebastianLuther@gmx.de \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox