From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C3299138247 for ; Fri, 17 Jan 2014 00:34:49 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0A469E0B8F; Fri, 17 Jan 2014 00:34:48 +0000 (UTC) Received: from albert.telenet-ops.be (albert.telenet-ops.be [195.130.137.90]) by pigeon.gentoo.org (Postfix) with ESMTP id 42261E0B80 for ; Fri, 17 Jan 2014 00:34:47 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by albert.telenet-ops.be with bizsmtp id Eoam1n00K2khLEN06oam4k; Fri, 17 Jan 2014 01:34:46 +0100 Date: Fri, 17 Jan 2014 01:33:42 +0100 From: Tom Wijsman To: antarus@gentoo.org Cc: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909). Message-ID: <20140117013342.2a39a72a@TOMWIJ-GENTOO> In-Reply-To: References: <1389830840-25848-1-git-send-email-tomwij@gentoo.org> <1389830840-25848-2-git-send-email-tomwij@gentoo.org> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.22; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/ZWWEhAJfjTVD4vwC5jusGvV"; protocol="application/pgp-signature" X-Archives-Salt: c6d7193f-7e65-426f-a2bf-e3b4a9bb4d5d X-Archives-Hash: dde8817cb3dae8c839fbe5db7f31ade0 --Sig_/ZWWEhAJfjTVD4vwC5jusGvV Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 15 Jan 2014 17:44:15 -0800 Alec Warner wrote: > Write these checks as functions Will do in v2, might also look into whether this part of the code can be refactored already into its own file; having it similar to the structure we have in Checks.py. We could then name Checks.py as SyntaxChecks.py and name this new file for the metadata checks of the loop as MetadataChecks.py; then later, we can look into creating VCSDiffChecks.py. Given that these files could grow, we will probably want to split the files up and put the split up files into directories like checks/syntax/, checks/metadata/ and so on. I really would love to see repoman refactored, redesigned and/or rewritten; but it is to soon for me to do this the most wise way, as I need to understand the code. I plan to do this 2 - 4 weeks from now. --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/ZWWEhAJfjTVD4vwC5jusGvV Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJS2HpmAAoJEJWyH81tNOV9Y0QH/322Ii+++3BXGh8GhNPyamtd dWMaVMpfpUo5cd+EuJr1LWqGVvf2fZ+DGnHfqOXipgHcL0TXgeQ73UNqTAS7gtrA Lb9/iDW3mpYDhZToKrFnzxjY8TJHvKdyuMoqZ+SnmWbcx6+L4D6T65CUGykLsHeB hqLMZZ3NzfbGwgkve5vyARMPZDI9mjmQGEbgVovckGgZMq6z4jbBuWneI5NclMuE Iahbv1cRrvsbt4++DDAgBgkaUA0mBOZy5DakR2hDhhOv3dWIm5LSEypk7cwztvTK nHgFUXxKBh6CXZHZGibVjPmxZlKEbXZIYRQHnrzeLvK2lZhSsApbfjDI2otXLno= =mVEJ -----END PGP SIGNATURE----- --Sig_/ZWWEhAJfjTVD4vwC5jusGvV--