From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 71568138247 for ; Thu, 16 Jan 2014 21:58:02 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8D706E0B75; Thu, 16 Jan 2014 21:57:59 +0000 (UTC) Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [195.130.132.51]) by pigeon.gentoo.org (Postfix) with ESMTP id D6745E0B1E for ; Thu, 16 Jan 2014 21:57:58 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by baptiste.telenet-ops.be with bizsmtp id Elxx1n00S2khLEN01lxxRd; Thu, 16 Jan 2014 22:57:57 +0100 Date: Thu, 16 Jan 2014 22:56:59 +0100 From: Tom Wijsman To: neurogeek@gentoo.org Cc: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084). Message-ID: <20140116225659.60b028cd@TOMWIJ-GENTOO> In-Reply-To: References: <1389830840-25848-1-git-send-email-tomwij@gentoo.org> <1389830840-25848-4-git-send-email-tomwij@gentoo.org> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.22; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/5gXavmv5hogqQ5QYe7QeG5."; protocol="application/pgp-signature" X-Archives-Salt: 949e8b86-34b6-41b4-bb8f-9cc4e5559f5e X-Archives-Hash: 2e5b563bdf0ab5cf6c468cff9cdc2bec --Sig_/5gXavmv5hogqQ5QYe7QeG5. Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 15 Jan 2014 20:23:26 -0500 "Jesus Rivero (Neurogeek)" wrote: > On Jan 15, 2014 7:08 PM, "Tom Wijsman" wrote: > > > PortageInternalVariableAssignment(LineCheck): e +=3D ' on line: %d' > > return e > > > > +class DeprecateG2CONF(LineCheck): > > + repoman_check_name =3D 'G2CONF.deprecated' > > + re =3D re.compile(r'.*G2CONF.*') > > + > > + def check(self, num, line): > > + """Run the check on line and return error if there > > is > one""" > > + m =3D self.re.match(line) > > + if m is not None: > > + return ("G2CONF on line %d is deprecated, > > see Gentoo bug #482084.") > > Are you missing the line number interpolation here? or %d is supposed > to be returned? That is filled in by the function which calls check(...), you can see the same happen with the "e +=3D ' on line: %d'" of the other check that made it into the context of this patch; when testing this, it worked properly in the repoman output. --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/5gXavmv5hogqQ5QYe7QeG5. Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJS2FWrAAoJEJWyH81tNOV9XcAH/12bMAeD87x7FkuZYeRO+IFY rbY5m5QWEdfVNgVLkFMUrYETyLe+8ZIrdp9ho4qFzIqHGFiF/31uyKfS26ZLfIOb l5ne85jsX/PcOthYflJ5ks1vtQOyiCbXs3TwDY6nfWthQITwi6b3wECXEGCo2W5K clYxPxTXIZNeDX67JSt1albu6TNnLLaFXkNoV1cWVjh37WhSut1P8Vh+o1W4T1Su vmN0V6TRzstObyzWxXBi80TvJY6OGK1x2pJU/fAlA46AknyGHO0ZrlQkj1t+JCPM 0qbi/z1N6DOt+ahc1MMweNJlX0Z7V2YkirbU2LB5/xJNFtywYkeJPBiISxyhyxQ= =BEkn -----END PGP SIGNATURE----- --Sig_/5gXavmv5hogqQ5QYe7QeG5.--