From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 77A27138247 for ; Thu, 16 Jan 2014 21:19:18 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EABC3E0BF6; Thu, 16 Jan 2014 21:19:17 +0000 (UTC) Received: from andre.telenet-ops.be (andre.telenet-ops.be [195.130.132.53]) by pigeon.gentoo.org (Postfix) with ESMTP id 2831AE0BA6 for ; Thu, 16 Jan 2014 21:19:17 +0000 (UTC) Received: from TOMWIJ-GENTOO ([94.226.55.127]) by andre.telenet-ops.be with bizsmtp id ElKF1n00u2khLEN01lKFNA; Thu, 16 Jan 2014 22:19:16 +0100 Date: Thu, 16 Jan 2014 22:18:14 +0100 From: Tom Wijsman To: antarus@gentoo.org Cc: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909). Message-ID: <20140116221814.2fac526b@TOMWIJ-GENTOO> In-Reply-To: References: <1389830840-25848-1-git-send-email-tomwij@gentoo.org> <1389830840-25848-2-git-send-email-tomwij@gentoo.org> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.22; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/o.p_Gi3uWV=mXIaC3Vh4QNN"; protocol="application/pgp-signature" X-Archives-Salt: 5a157b6f-c905-44c0-b668-55cacb6ef756 X-Archives-Hash: 670746506c11540a654711b82508612a --Sig_/o.p_Gi3uWV=mXIaC3Vh4QNN Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 15 Jan 2014 17:44:15 -0800 Alec Warner wrote: > On Wed, Jan 15, 2014 at 4:07 PM, Tom Wijsman > wrote: >=20 > > --- > > bin/repoman | 53 > > +++++++++++++++++++++++++++++++++++++++++++++++++++++ man/repoman.1 > > | 4 ++++ 2 files changed, 57 insertions(+) > > > > > I urge you to not author new checks like this. /usr/bin/repoman is > already a mess. >=20 > Write these checks as functions, put them in a different file, and > just call them from the giant messy loop. At least that way the > checks are self contained (great for avoiding things like variable > re-use or shadowing). My plan is to first work a bit on repoman to get to know it, then when knowing better where everything is work on refactoring it. If I start to refactor right away, or start adding random files without knowing where everything is; I would create a more broken design than it is. Don't worry, I plan on a fully refactored Portage as well as good practices when adding new checks; which will definitely become necessary as we go forward. There's ~80 bugs, imagine all the code that that would bring; definitely don't want those files to grow much longer. --=20 With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D --Sig_/o.p_Gi3uWV=mXIaC3Vh4QNN Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJS2EyZAAoJEJWyH81tNOV932gIAL1p6WVWr3AZAEt5nQBMMNXa BSRpLWTvdL9IInveXt2NFn6jw47Ehgd5ZT9jX62Hrn0AjZfTwdRI0XNxyYo5fk7S yLtGUJRNVSkSSJ+t2t4pK1MpFgz7BCsnRSqqXAxncLywOUMz4ZsAFpjgCPmd6M/Z mCIvxZ0JzDUBPBPkr6QYwiYfIRCQbLeCqqRTkV3tfjEL3MI7HAnOKX9R0a7oyNTQ zL0BAbG1Bv/jB1qsWEKCB95+w7akT5hYVwnh9NjC0dSUwclE4lRTGfzH1xw8nVqp rK3+VXJ1/WjNaQaRKxgHqKjUhz2dpD46Nheke+mY+YWp9GBkgNymoXJIemRlx1s= =rUmb -----END PGP SIGNATURE----- --Sig_/o.p_Gi3uWV=mXIaC3Vh4QNN--