[gentoo-portage-dev] Commit Policy

[gentoo-portage-dev] Commit Policy

[Brian Dolbec]

[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]

First off.  Welcome and than you for responding to help with portage.

With this many people, we should be able to make good progress without
overloading any one person.

General rule is to submit all patches to this list for review and
approval before committing.

Remember to do these always:
 1) run pyflakes on your changes to check for faults, misssing imports,
variables undefined,...

2) run the testsuite to check for breakage.  It is in the base directory
called runtests.sh.  Please try to test it with all minimum supported
python versions, but if you have pypy, and some others, then great.

3) any new code that could break things, make a test for it if at all
possible.


The general exception for patch submittal is for trivial changes such as
typo fixes, etc..

It will take a bit of time for everyone to acclimate themselves into our
new team.  So, I was thinking we give it 2 months, then hold an election
for lead in March.  Is that alright with everyone?

Thanks
-- 
Brian Dolbec <dolsen@gentoo.org>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 620 bytes --]

Re: [gentoo-portage-dev] Commit Policy

[Matthew Thode]

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

On 01/10/2014 04:35 AM, Brian Dolbec wrote:
> First off.  Welcome and than you for responding to help with portage.
> 
> With this many people, we should be able to make good progress without
> overloading any one person.
> 
> General rule is to submit all patches to this list for review and
> approval before committing.
> 
> Remember to do these always:
>  1) run pyflakes on your changes to check for faults, misssing imports,
> variables undefined,...
> 
> 2) run the testsuite to check for breakage.  It is in the base directory
> called runtests.sh.  Please try to test it with all minimum supported
> python versions, but if you have pypy, and some others, then great.
> 
> 3) any new code that could break things, make a test for it if at all
> possible.
> 
> 
> The general exception for patch submittal is for trivial changes such as
> typo fixes, etc..
> 
> It will take a bit of time for everyone to acclimate themselves into our
> new team.  So, I was thinking we give it 2 months, then hold an election
> for lead in March.  Is that alright with everyone?
> 
> Thanks
> 
sounds good to me

-- 
-- Matthew Thode (prometheanfire)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-portage-dev] Commit Policy

[Pavel Kazakov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/10/2014 02:35 AM, Brian Dolbec wrote:
>
> It will take a bit of time for everyone to acclimate themselves into our
> new team.  So, I was thinking we give it 2 months, then hold an election
> for lead in March.  Is that alright with everyone?

Works for me.

Regards,
Pavel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJS0DhaAAoJENb1ecI556sujNYP/i+2zDAXqWSXfLWcaodz5Q2N
AsFJQTy2dnZRlG1BTVdcsh+tS5P7VpgLkb6C1K+G5fyI81qjSmiIEuPowMqo78Gs
Rhx3Qf7QUusGi9KQau7xCuxqpYSqWXiHEf3QwP+iMTBFYmgcPwUddlC20FN8C2u1
5FAF99YtiZqbLABIZ7KeTUkCWYkHC8G/Es2ZK0KTqL+qZrnz11FtXlmFzlDuOd+r
j2Nx9Tw7A4bKTXL2rqzhH7BxvySc1RLCfFxqGnovckCves5BJIp6/9ptEMq2NbO3
qvcAj5ar8j38YRuzePbHag3AyfQVeHnNrni1ETnNb45QmbbnBAuJuQdoLQOWU3TG
488K7KQrnW0s8aNeE0kUX/dFtapUwqcYcWpAbermCS9W00mWinMcgBPq4JfF58fo
DBnkOt5Vt/kEC2y0q2YsQe8QsTT8Xj2R3tuHCYD3uEbVUlvl/Hml7J76EbBHpNo+
1yIYHhnnazTahrhVyjlwd3gRPD/V7Jq28CSkyuVB/aX8CXJOh+8E0pqfqWJH69xc
LYAdfTsVh/rfXfUP2dY18Li/MmfrtpRiRSV3XzeJPl3HrPIdFuvCTvuWPhmlL6OZ
YOcepBLv2TVPuOtABgNwxVUt3VJ20KVVdmthUMocq07b8hkxqRgX/Vok18weXic+
PXWx1sutvKXT15F8Hjoz
=zJZs
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] Commit Policy

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Sounds good. A couple of comments,

On 10/01/14 11:35, Brian Dolbec wrote:
> General rule is to submit all patches to this list for review and 
> approval before committing.
s/committ/push

> 1) run pyflakes on your changes to check for faults, misssing 
> imports, variables undefined,...
I recommend getting editor plug-ins that do this for you. syntastic is
great for vim.
- -- 
Alexander
alexander@plaimi.net
http://plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlLQtAkACgkQRtClrXBQc7WjhAD/XZtujqvP+UgX1Vg94rb3g2HJ
0BIeCLMj+tWvcj5mzfQA/iuP05SmTJx8taAZrZxdXmSaax1dwHD6De9G+U1TfGYa
=FdTX
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] Commit Policy

[Sebastian Luther]

Am 10.01.2014 11:35, schrieb Brian Dolbec:
> First off.  Welcome and than you for responding to help with
> portage.
> 
> With this many people, we should be able to make good progress
> without overloading any one person.
> 
> General rule is to submit all patches to this list for review and 
> approval before committing.
> 
> Remember to do these always: 1) run pyflakes on your changes to
> check for faults, misssing imports, variables undefined,...
> 
> 2) run the testsuite to check for breakage.  It is in the base
> directory called runtests.sh.  Please try to test it with all
> minimum supported python versions, but if you have pypy, and some
> others, then great.
> 
> 3) any new code that could break things, make a test for it if at
> all possible.
> 
> 
> The general exception for patch submittal is for trivial changes
> such as typo fixes, etc..
> 
> It will take a bit of time for everyone to acclimate themselves
> into our new team.  So, I was thinking we give it 2 months, then
> hold an election for lead in March.  Is that alright with
> everyone?
> 
> Thanks
> 

One more useful thing:

Put this in ~/.gitconfig:
[color]
	ui = auto

This way git diff will use colors, including highlighting of trailing
whitespace.

Re: [gentoo-portage-dev] Commit Policy

[Brian Dolbec]

[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]

On Mon, 2014-01-13 at 07:43 +0100, Sebastian Luther wrote:
> Am 10.01.2014 11:35, schrieb Brian Dolbec:
> > First off.  Welcome and than you for responding to help with
> > portage.
> > 
> > With this many people, we should be able to make good progress
> > without overloading any one person.
> > 
> > General rule is to submit all patches to this list for review and 
> > approval before committing.
> > 
> > Remember to do these always: 1) run pyflakes on your changes to
> > check for faults, misssing imports, variables undefined,...
> > 
> > 2) run the testsuite to check for breakage.  It is in the base
> > directory called runtests.sh.  Please try to test it with all
> > minimum supported python versions, but if you have pypy, and some
> > others, then great.
> > 
> > 3) any new code that could break things, make a test for it if at
> > all possible.
> > 
> > 
> > The general exception for patch submittal is for trivial changes
> > such as typo fixes, etc..
> > 
> > It will take a bit of time for everyone to acclimate themselves
> > into our new team.  So, I was thinking we give it 2 months, then
> > hold an election for lead in March.  Is that alright with
> > everyone?
> > 
> > Thanks
> > 
> 
> One more useful thing:
> 
> Put this in ~/.gitconfig:
> [color]
> 	ui = auto
> 
> This way git diff will use colors, including highlighting of trailing
> whitespace.
> 
> 
> 

I use an editor that I have set for both showing whitespace (you see
tabs, spaces) and auto-strips trailing whitespace on save.

nice tip for the git diff.

I like using dev-vcs/gitg for doing commits, viewing different branch
trees, cherry-picking (in color too).  For commits it lets you pick
changes 1 at a time (+ or -) when you've done several changes, but wish
to split them into logical commits.  Handy when you spot things that
need fixing, but don't want to forget to do after your current change
session & commit.

-- 
Brian Dolbec <dolsen@gentoo.org>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 620 bytes --]

Re: [gentoo-portage-dev] Commit Policy

[Yixun Lan]

On Sun, Jan 12, 2014 at 11:29:34PM -0800, Brian Dolbec wrote:
> On Mon, 2014-01-13 at 07:43 +0100, Sebastian Luther wrote:
> > 
> > One more useful thing:
> > 
> > Put this in ~/.gitconfig:
> > [color]
> > 	ui = auto
> > 
> > This way git diff will use colors, including highlighting of trailing
> > whitespace.
> > 
> > 
> > 
> 
> I use an editor that I have set for both showing whitespace (you see
> tabs, spaces) and auto-strips trailing whitespace on save.
> 
> nice tip for the git diff.
> 
> I like using dev-vcs/gitg for doing commits, viewing different branch
> trees, cherry-picking (in color too).  For commits it lets you pick
> changes 1 at a time (+ or -) when you've done several changes, but wish
> to split them into logical commits.  Handy when you spot things that
> need fixing, but don't want to forget to do after your current change
> session & commit.
Hope I'm not making too much noise here ;-)
if you want to amend your git commits a lot,
saying, movie commits up/down, merge/split them
you could try dev-vcs/stgit, it's my favorite!
> 
> -- 
> Brian Dolbec <dolsen@gentoo.org>

Lan

[gentoo-portage-dev] Re: Commit Policy

[W. Trevor King]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

On Mon, Jan 13, 2014 at 07:43:27AM +0100, Sebastian Luther wrote:
> Put this in ~/.gitconfig:
> [color]
> 	ui = auto

This is the default for Git >=1.8.4, so you don't need to bother
setting it by hand if you're running an ~arch ;).

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-portage-dev] Commit Policy

[Tom Wijsman]

[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]

On Mon, 13 Jan 2014 07:43:27 +0100
Sebastian Luther <SebastianLuther@gmx.de> wrote:

> Am 10.01.2014 11:35, schrieb Brian Dolbec:
> > First off.  Welcome and than you for responding to help with
> > portage.
> > 
> > With this many people, we should be able to make good progress
> > without overloading any one person.
> > 
> > General rule is to submit all patches to this list for review and 
> > approval before committing.
> > 
> > Remember to do these always: 1) run pyflakes on your changes to
> > check for faults, misssing imports, variables undefined,...
> > 
> > 2) run the testsuite to check for breakage.  It is in the base
> > directory called runtests.sh.  Please try to test it with all
> > minimum supported python versions, but if you have pypy, and some
> > others, then great.
> > 
> > 3) any new code that could break things, make a test for it if at
> > all possible.
> > 
> > 
> > The general exception for patch submittal is for trivial changes
> > such as typo fixes, etc..
> > 
> > It will take a bit of time for everyone to acclimate themselves
> > into our new team.  So, I was thinking we give it 2 months, then
> > hold an election for lead in March.  Is that alright with
> > everyone?
> > 
> > Thanks
> > 
> 
> One more useful thing:
> 
> Put this in ~/.gitconfig:
> [color]
> 	ui = auto
> 
> This way git diff will use colors, including highlighting of trailing
> whitespace.

Instead of this, we can add vapier's suggestion to set a proper name
and e-mail; we can add other minor issues like these to the policy in
the future as they become more visible (or Git functionality changes).

-- 
With kind regards,

Tom Wijsman (TomWij)
Gentoo Developer

E-mail address  : TomWij@gentoo.org
GPG Public Key  : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2  ABF0 95B2 1FCD 6D34 E57D

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

Re: [gentoo-portage-dev] Commit Policy

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 15/01/14 04:22, Tom Wijsman wrote:
> Instead of this, we can add vapier's suggestion to set a proper
> name and e-mail; we can add other minor issues like these to the
> policy in the future as they become more visible (or Git
> functionality changes).
These are just some tips that Portage devs have found to improve their
workflow. They belong in the Wiki. Someone with edit rights should add
a link or section for it.

- -- 
Alexander
alexander@plaimi.net
http://plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlLWSg8ACgkQRtClrXBQc7V7FwD/Yc+hTAaIXhrYaDnW0xqE047p
0FIWN2tbf1gR9kXDz9ABAIfei6LeqOKYe5Cs1rQPTunk8b2Aird91YTTKVFKBWpi
=aKsI
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] Commit Policy

[Tom Wijsman]

[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]

On Fri, 10 Jan 2014 02:35:12 -0800
Brian Dolbec <dolsen@gentoo.org> wrote:

> First off.  Welcome and than you for responding to help with portage.
>
> With this many people, we should be able to make good progress without
> overloading any one person.

Thank you for taking the step forward to look for them and lead them.
 
> General rule is to submit all patches to this list for review and
> approval before committing.
> 
> Remember to do these always:
>  1) run pyflakes on your changes to check for faults, misssing
> imports, variables undefined,...
> 
> 2) run the testsuite to check for breakage.  It is in the base
> directory called runtests.sh.  Please try to test it with all minimum
> supported python versions, but if you have pypy, and some others,
> then great.
> 
> 3) any new code that could break things, make a test for it if at all
> possible.
> 
> 
> The general exception for patch submittal is for trivial changes such
> as typo fixes, etc..
> 
> It will take a bit of time for everyone to acclimate themselves into
> our new team.  So, I was thinking we give it 2 months, then hold an
> election for lead in March.  Is that alright with everyone?

Looks good; 2 months is indeed also handy to get to learn each other,
as well as for people to consider whether they want to nominate.

-- 
With kind regards,

Tom Wijsman (TomWij)
Gentoo Developer

E-mail address  : TomWij@gentoo.org
GPG Public Key  : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2  ABF0 95B2 1FCD 6D34 E57D

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]