From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: "Jesus Rivero (Neurogeek)" <neurogeek@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH] [REV] Added support for variable expansion in source command. wrt bug #490896
Date: Mon, 13 Jan 2014 18:28:46 -0500 [thread overview]
Message-ID: <201401131828.47173.vapier@gentoo.org> (raw)
In-Reply-To: <CAD3zpD=J0pNkAZ4ozXvFQAu1qYzJtQDe+-frX-kgD1Zjskh7LQ@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 464 bytes --]
On Sunday 12 January 2014 18:57:43 Jesus Rivero (Neurogeek) wrote:
> In the previous patch, I didn't notice an error in the unittest I wrote for
> the feature.
> Attached is the correct patch, please disregard the previous one.
please use standard git tags which means the subject line would be:
[PATCH v2] Added support for ....
also please use `git send-email` rather than attaching files. it makes things
harder to review when you attach.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-13 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 23:57 [gentoo-portage-dev] [PATCH] [REV] Added support for variable expansion in source command. wrt bug #490896 Jesus Rivero (Neurogeek)
2014-01-13 6:14 ` Pavel Kazakov
2014-01-13 23:28 ` Mike Frysinger [this message]
2014-01-13 23:52 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401131828.47173.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=neurogeek@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox