From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 268651381F3 for ; Mon, 21 Oct 2013 03:00:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 268B0E0B7B; Mon, 21 Oct 2013 03:00:05 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6F46CE0B60 for ; Mon, 21 Oct 2013 03:00:04 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id E133B33EF9A; Mon, 21 Oct 2013 03:00:01 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] xattr: centralize the various shims in one place Date: Sun, 20 Oct 2013 23:00:06 -0400 User-Agent: KMail/1.13.7 (Linux/3.10.6; KDE/4.6.5; x86_64; ; ) Cc: Arfrever Frehtes Taifersar Arahesis References: <1381957406-21749-1-git-send-email-vapier@gentoo.org> <201310162253.34929.vapier@gentoo.org> <201310170542.26667.Arfrever.FTA@gmail.com> In-Reply-To: <201310170542.26667.Arfrever.FTA@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2311276.mR1aF01O4P"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201310202300.07264.vapier@gentoo.org> X-Archives-Salt: 8478bc68-60f5-41bf-99bd-3f136c95e496 X-Archives-Hash: 83cf9901be1ec06a5d50a5f661578f24 --nextPart2311276.mR1aF01O4P Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 16 October 2013 23:42:26 Arfrever Frehtes Taifersar wrote: > 2013-10-17 04:53 Mike Frysinger napisa=C5=82(a): > > On Wednesday 16 October 2013 22:51:17 Mike Frysinger wrote: > > > On Wednesday 16 October 2013 20:02:50 Arfrever Frehtes wrote: > > > > 2013-10-16 23:03 Mike Frysinger napisa=C5=82(a): > > > > > Rather than each module implementing its own shim around the > > > > > various methods for accessing extended attributes, start a > > > > > dedicated module that exports a consistent API. > > > >=20 > > > > Some things are incompatible with Python 3. > > > > See other comments below. > > >=20 > > > i can run a linter on the code (probably should make this a git hook)= =2E=20 > > > i'm interested more in review on the bigger picture. > >=20 > > also, none of your comments were py3 issues that i saw >=20 > I said "other comments", so I meant comments not related to incompatibili= ty > with Python 3. well, w/out providing specific concerns, it's hard to address feedback > About incompatibility with Python 3: > - subprocess.check_output(), subprocess.Popen().stdout.read(), > subprocess.Popen().stderr.read() return bytes, which is incorrectly > compared with str in your patches. i've changed the mock code to use subprocess directly so the tests catch th= is > - dict.iteritems() was renamed to dict.items() (and its return type was > changed from dictionary-itemiterator to dict_items, but it does not matter > here). fixed > - Queue module was renamed to queue. i've sent a patch upstream for this > - cStringIO module should not be used. io module is a replacement availab= le > since Python 2.6. unfortunately, that doesn't work as well as it should. python 2.7's interf= ace=20 is annoyingly different when using other python 2.7 modules. i'll have the= =20 code import the old module and then fallback to using the new io module. > - Maybe other problems... sorry, but this isn't useful. i'm going to run the unittests against pytho= n=20 3.2 and 3.3 and once those pass, i'm done looking at it. =2Dmike --nextPart2311276.mR1aF01O4P Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJSZJi3AAoJEEFjO5/oN/WBkl4QANCCsyf+W2iRjxbiQJpeXZui UTy0bhs45VmXg31RtTYCfC6WabKJGamnMILEc1dzQ0I5FCyhzsE2tCM+E/dP/eLF qf4SR60ORznWEv1Wl1LJrPvYvePsJAfufkrtqOSc4lw/79jSUQDUkPuW31JpqaHR lWS9bEtrQwsQsBg9zVRbvbVD6VQGE6XHDzvlmIbmb0aUUwcO3GTOQ231SKaehhLX dy5N9qy2WPrsdD8K5DzqYYgpaMGgZmx+j7nPbatqGpSC6KrL93AWJFZIt+4L0LlB xukhK1YlWghWkT1GrcKQ+vi7VHyrST6bPAmBVG6sdn8uj4S6T8koVPU1cMOyEuoZ c8cKK8vP1hisFdVlliE+GR/WaKuu2VWF8dnMMsgRzcrLckGMYFbPAMMhESky3iFg giV4yKG/7VZ36/xkvCPRaOJju1oeOQXAxkmVKTdZRgp5B92RF0vo0Qw56VmpP6OS FID1D19Ef9hOIAdCN7LSDx2Z1ovvKww5/3+dhHv3YmErMw+1NZPQBZcb2xnG0Hrg hhskLC1FJIvWASnWj2m5YgczG393jpMcFlDA9FG4ZwAhXMWBWk6yEAIQSv0U8+Ex JsWo4jO7D2yUMQUSEYhxH/prcg665z8/6g6ro5g0JHBT5QH5ieJlKhVhccMs9bT5 OD7BB9oVPNuR9RYmpFsT =ndf/ -----END PGP SIGNATURE----- --nextPart2311276.mR1aF01O4P--