From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id DA4061381F3 for ; Thu, 17 Oct 2013 03:43:00 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8123AE099B; Thu, 17 Oct 2013 03:42:50 +0000 (UTC) Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com [209.85.215.179]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C1281E0944 for ; Thu, 17 Oct 2013 03:42:49 +0000 (UTC) Received: by mail-ea0-f179.google.com with SMTP id b10so765262eae.10 for ; Wed, 16 Oct 2013 20:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:user-agent:references:in-reply-to:mime-version :content-type:content-transfer-encoding:message-id; bh=RfutAAduMlXQqHXuVypMW9ZjNpqU8RZJ9b+WCdanMWI=; b=kik6f7+26eu165FjUCcWLVrWCtPcidbQNoynXcenYJj4m5VlyLIFY3qRdZIOzUInWW FmWFIc9iIfMikwPnsd4ksS5K8iGYKYM0kZ35EDFTNrue7y7w3Po+DcscvoAcU8Fhj/29 VJr+3ymzhv9nbavQhooaxEm+4IfPh0l4NApL3C65HcSBgarLiWeEOuRbLMNj09EuW2EE AJk8wZz9zYMfIMXDDHQgOrKU9aXA7DPq+w6cWZ4OfTl14k7HUJkgORwCZP1gHonYgvLS us36oMoSWG9JHXX7HJUJPTTMN0OSgwrAR+Rc+DAUtdh1jLz885JxZi3jYhNy6I03EKb+ qqcA== X-Received: by 10.14.109.134 with SMTP id s6mr164705eeg.84.1381981368452; Wed, 16 Oct 2013 20:42:48 -0700 (PDT) Received: from afta-picea.localnet (202-141-251-94.net.stream.pl. [94.251.141.202]) by mx.google.com with ESMTPSA id f49sm187295356eec.7.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Oct 2013 20:42:47 -0700 (PDT) From: Arfrever Frehtes Taifersar Arahesis To: Gentoo Portage Development Subject: Re: [gentoo-portage-dev] [PATCH] xattr: centralize the various shims in one place Date: Thu, 17 Oct 2013 05:42:26 +0200 User-Agent: KMail (GNU/Linux) References: <1381957406-21749-1-git-send-email-vapier@gentoo.org> <201310162251.18290.vapier@gentoo.org> <201310162253.34929.vapier@gentoo.org> In-Reply-To: <201310162253.34929.vapier@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2170528.GhvobPc8aV"; protocol="application/pgp-signature"; micalg=pgp-sha512 Content-Transfer-Encoding: 7bit Message-Id: <201310170542.26667.Arfrever.FTA@gmail.com> X-Archives-Salt: 73215207-9550-4fcd-8994-c04be742c27d X-Archives-Hash: a14475c47a1145c1746781a2edfff7a5 --nextPart2170528.GhvobPc8aV Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable 2013-10-17 04:53 Mike Frysinger napisa=C5=82(a): > On Wednesday 16 October 2013 22:51:17 Mike Frysinger wrote: > > On Wednesday 16 October 2013 20:02:50 Arfrever Frehtes Taifersar Arahes= is > >=20 > > wrote: > > > 2013-10-16 23:03 Mike Frysinger napisa=C5=82(a): > > > > Rather than each module implementing its own shim around the various > > > > methods for accessing extended attributes, start a dedicated module > > > > that exports a consistent API. > > >=20 > > > Some things are incompatible with Python 3. > > > See other comments below. > >=20 > > i can run a linter on the code (probably should make this a git hook). = i'm > > interested more in review on the bigger picture. >=20 > also, none of your comments were py3 issues that i saw I said "other comments", so I meant comments not related to incompatibility= with Python 3. About incompatibility with Python 3: =2D subprocess.check_output(), subprocess.Popen().stdout.read(), subprocess= =2EPopen().stderr.read() return bytes, which is incorrectly compared with str in your patches. =2D dict.iteritems() was renamed to dict.items() (and its return type was c= hanged from dictionary-itemiterator to dict_items, but it does not matter here). =2D Queue module was renamed to queue. =2D cStringIO module should not be used. io module is a replacement availab= le since Python 2.6. =2D Maybe other problems... =2D- Arfrever Frehtes Taifersar Arahesis --nextPart2170528.GhvobPc8aV Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAABCgAGBQJSX1yiAAoJEA1v8+vOu0V05xcP/0O3Fyh3EDW6+wprdBLIj7Jw eHTuKZWt4RZNiqo9JaP3rhCqH1Htvu8+zrqKhWFD43X9yuXgtQkp8X488zX/ttPv pZMiNqe8ChQlueeKSJcWBmTn8yPAHecLrOvRM/r1Hfe4uqpQbQ40O3zT2N3rR9Ml j3Vk1bCfZIGEiQ+1U4SWV9UQHYDnvJBnlOb7zs5NQA6roeVVZw8RmryG++CyMzPX NloB2BURxejFUU2QhlOJTTx06N+dfoUpQTFa8oHz5ks0hORx5luV4J57iohm7BeR ytrpRyNV339KSkep2zPJmlLCy1sjsWy3k+3XyTlUB6L30WxatDbD1FVRaQ3rboeq AIpW4ngla2Bbu6UniWCOu0G5cGEBBjwrFHfgUhXxut6Y582oU+P4COZGhzwN9MLg YYgY2p9cAJk5sNesQH+0Pp7LzloQc4MMvbiC/GdsDNdh8qE5/j/L0DSm0APvdBBZ SB5Np6jc/k+N+1uSNhkvxW1w/lMl8kA/lpU/TPxwQQdpCHVikkg6hXjJHBgiX/RJ xvqdlUoH5YAnovEuReEaQQQpYi72a0QhA6dU5sglmhvHE0yxxaXxrSK4nNlqPf2/ s56mEHmjPAyCJVj3Zq5+hrn2VUGF5wMaVQB1pYeYZcRiEdBqz9WsC2gm6V/ihMKU JMy5r1DEV7mT8av4kNYC =HR4J -----END PGP SIGNATURE----- --nextPart2170528.GhvobPc8aV--