* [gentoo-portage-dev] [PATCH] depgraph: tweak "required by" message format
@ 2013-02-18 2:21 Mike Frysinger
2013-02-18 3:18 ` Zac Medico
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2013-02-18 2:21 UTC (permalink / raw
To: gentoo-portage-dev
The current output format for listing a chain of dependencies produces
one long flat line that can be hard to read. For example, if you mask
dev-lang/ruby and then try to install dev-ruby/json, you'll see:
The following mask changes are necessary to proceed:
(see "package.unmask" in the portage(5) man page for more details)
=dev-lang/ruby-1.9.3_p385
=dev-lang/ruby-1.8.7_p371
Tracing your way through that list is not easy. Instead, let's use
newlines and now we get:
The following mask changes are necessary to proceed:
(see "package.unmask" in the portage(5) man page for more details)
=dev-lang/ruby-1.9.3_p385
=dev-lang/ruby-1.8.7_p371
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
pym/_emerge/depgraph.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
index bab1c32..6f7b673 100644
--- a/pym/_emerge/depgraph.py
+++ b/pym/_emerge/depgraph.py
@@ -3617,7 +3617,7 @@ class depgraph(object):
else:
display_list.append("required by %s" % node)
- msg = "#" + ", ".join(display_list) + "\n"
+ msg = "# " + "\n# ".join(display_list) + "\n"
return msg
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] depgraph: tweak "required by" message format
2013-02-18 2:21 [gentoo-portage-dev] [PATCH] depgraph: tweak "required by" message format Mike Frysinger
@ 2013-02-18 3:18 ` Zac Medico
2013-02-18 4:43 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Zac Medico @ 2013-02-18 3:18 UTC (permalink / raw
To: gentoo-portage-dev
On 02/17/2013 06:21 PM, Mike Frysinger wrote:
> The current output format for listing a chain of dependencies produces
> one long flat line that can be hard to read. For example, if you mask
> dev-lang/ruby and then try to install dev-ruby/json, you'll see:
Looks like the comments got stripped by git-commit or something.
Anyway, looks good to me.
--
Thanks,
Zac
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] depgraph: tweak "required by" message format
2013-02-18 3:18 ` Zac Medico
@ 2013-02-18 4:43 ` Mike Frysinger
0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2013-02-18 4:43 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Zac Medico
[-- Attachment #1: Type: Text/Plain, Size: 428 bytes --]
On Sunday 17 February 2013 22:18:30 Zac Medico wrote:
> On 02/17/2013 06:21 PM, Mike Frysinger wrote:
> > The current output format for listing a chain of dependencies produces
> > one long flat line that can be hard to read. For example, if you mask
> > dev-lang/ruby and then try to install dev-ruby/json, you'll see:
>
> Looks like the comments got stripped by git-commit or something.
ah, so it did. i'll fix that.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-18 4:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-18 2:21 [gentoo-portage-dev] [PATCH] depgraph: tweak "required by" message format Mike Frysinger
2013-02-18 3:18 ` Zac Medico
2013-02-18 4:43 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox