public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] About adding a repoman check to test for missing files in FILESDIR
@ 2012-10-08 18:26 Pacho Ramos
  2012-10-08 18:32 ` Zac Medico
  0 siblings, 1 reply; 4+ messages in thread
From: Pacho Ramos @ 2012-10-08 18:26 UTC (permalink / raw
  To: gentoo-portage-dev

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hello

Sometime ago this was already discussed but, if I don't misremember, it
was hard to implement a check for repoman to prevent us from forgetting
to commit new patches. Maybe the check could simply check if all
"${FILESDIR}" files are present? The idea is that it could simply check
of that files existence, if they are not present, show a warn (not a
"hard" warn as it could be a false positive I guess). Regarding that
file not being added to cvs tree, it doesn't show so much problems as
that error is already shown at commit time (file present but not added
to cvs)

Thanks

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-portage-dev] About adding a repoman check to test for missing files in FILESDIR
  2012-10-08 18:26 [gentoo-portage-dev] About adding a repoman check to test for missing files in FILESDIR Pacho Ramos
@ 2012-10-08 18:32 ` Zac Medico
  2012-10-08 18:47   ` Pacho Ramos
  0 siblings, 1 reply; 4+ messages in thread
From: Zac Medico @ 2012-10-08 18:32 UTC (permalink / raw
  To: gentoo-portage-dev

On 10/08/2012 11:26 AM, Pacho Ramos wrote:
> Hello
> 
> Sometime ago this was already discussed but, if I don't misremember, it
> was hard to implement a check for repoman to prevent us from forgetting
> to commit new patches. Maybe the check could simply check if all
> "${FILESDIR}" files are present? The idea is that it could simply check
> of that files existence, if they are not present, show a warn (not a
> "hard" warn as it could be a false positive I guess). Regarding that
> file not being added to cvs tree, it doesn't show so much problems as
> that error is already shown at commit time (file present but not added
> to cvs)

Given the expressiveness of the bash language, it's really a non-trivial
thing to check without actually executing bash. See discussion here:

  https://bugs.gentoo.org/show_bug.cgi?id=431196
-- 
Thanks,
Zac


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-portage-dev] About adding a repoman check to test for missing files in FILESDIR
  2012-10-08 18:32 ` Zac Medico
@ 2012-10-08 18:47   ` Pacho Ramos
  2012-10-09  6:49     ` Fabian Groffen
  0 siblings, 1 reply; 4+ messages in thread
From: Pacho Ramos @ 2012-10-08 18:47 UTC (permalink / raw
  To: gentoo-portage-dev

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

El lun, 08-10-2012 a las 11:32 -0700, Zac Medico escribió:
> On 10/08/2012 11:26 AM, Pacho Ramos wrote:
> > Hello
> > 
> > Sometime ago this was already discussed but, if I don't misremember, it
> > was hard to implement a check for repoman to prevent us from forgetting
> > to commit new patches. Maybe the check could simply check if all
> > "${FILESDIR}" files are present? The idea is that it could simply check
> > of that files existence, if they are not present, show a warn (not a
> > "hard" warn as it could be a false positive I guess). Regarding that
> > file not being added to cvs tree, it doesn't show so much problems as
> > that error is already shown at commit time (file present but not added
> > to cvs)
> 
> Given the expressiveness of the bash language, it's really a non-trivial
> thing to check without actually executing bash. See discussion here:
> 
>   https://bugs.gentoo.org/show_bug.cgi?id=431196

Then, maybe I could have a custom repoman script that would check for
them in my "files/" directory (either using bash to check for them or
simply running "ls")  :/

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-portage-dev] About adding a repoman check to test for missing files in FILESDIR
  2012-10-08 18:47   ` Pacho Ramos
@ 2012-10-09  6:49     ` Fabian Groffen
  0 siblings, 0 replies; 4+ messages in thread
From: Fabian Groffen @ 2012-10-09  6:49 UTC (permalink / raw
  To: gentoo-portage-dev

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

On 08-10-2012 20:47:41 +0200, Pacho Ramos wrote:
> El lun, 08-10-2012 a las 11:32 -0700, Zac Medico escribió:
> > Given the expressiveness of the bash language, it's really a non-trivial
> > thing to check without actually executing bash. See discussion here:
> > 
> >   https://bugs.gentoo.org/show_bug.cgi?id=431196
> 
> Then, maybe I could have a custom repoman script that would check for
> them in my "files/" directory (either using bash to check for them or
> simply running "ls")  :/

Yes, but still it is very hard to make it 100% reliable.  If you stick
to simple "${FILESDIR}"/${PN}-x.y.patch patterns, it's very well
feasible, though.  See for inspiration the fetch_files() function from [1].


[1] http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/scripts/eupdate.in


-- 
Fabian Groffen
Gentoo on a different level

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-10-09  9:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-08 18:26 [gentoo-portage-dev] About adding a repoman check to test for missing files in FILESDIR Pacho Ramos
2012-10-08 18:32 ` Zac Medico
2012-10-08 18:47   ` Pacho Ramos
2012-10-09  6:49     ` Fabian Groffen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox