public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Zac Medico <zmedico@gentoo.org>
Cc: gentoo-portage-dev@lists.gentoo.org, Ambroz Bizjak <ambrop7@gmail.com>
Subject: Re: [gentoo-portage-dev] [PATCH] Implement host dependencies (HDEPEND) and dependencies only in affect when ROOT != / (targetroot flag).
Date: Mon, 24 Sep 2012 00:39:30 -0400	[thread overview]
Message-ID: <201209240039.31170.vapier@gentoo.org> (raw)
In-Reply-To: <505FD926.1030805@gentoo.org>

[-- Attachment #1: Type: Text/Plain, Size: 836 bytes --]

On Sunday 23 September 2012 23:53:10 Zac Medico wrote:
> On 09/23/2012 08:44 PM, Mike Frysinger wrote:
> > On Sunday 23 September 2012 22:06:43 Ambroz Bizjak wrote:
> >> +	case "$EAPI" in
> > 
> > case ${EAPI} in
> 
> If somebody manages to corrupt the EAPI with an invalid value containing
> space, then you can get a bash syntax error there if ${EAPI} is
> unquoted. Yeah, it's a user error, but it could confuse them even more
> than they are already if they see the syntax error and think that
> portage is at fault. Also, we might consider that a corrupt EAPI can
> come from a binary package (or /var/db/pkg) enviroment.bz2, and so it
> may not even be the current user who is at fault.

i don't think that's true.  case is sane unlike `test` and `[`.
	$ f='a b c'; case ${f} in *) echo yeah;; esac
	yeah
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-09-24  6:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24  2:06 [gentoo-portage-dev] [PATCH] Implement host dependencies and targetroot USE flag Ambroz Bizjak
2012-09-24  2:06 ` [gentoo-portage-dev] [PATCH] Implement host dependencies (HDEPEND) and dependencies only in affect when ROOT != / (targetroot flag) Ambroz Bizjak
2012-09-24  3:44   ` Mike Frysinger
2012-09-24  3:53     ` Zac Medico
2012-09-24  4:39       ` Mike Frysinger [this message]
2012-09-24  4:49         ` Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209240039.31170.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=ambrop7@gmail.com \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    --cc=zmedico@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox