public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] [PATCH] drop support for QA_DT_HASH/QA_STRICT_DT_HASH
@ 2012-09-24  0:49 Mike Frysinger
  2012-09-24  1:39 ` Zac Medico
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2012-09-24  0:49 UTC (permalink / raw
  To: gentoo-portage-dev

These variables have been deprecated in favor of the new variables
QA_STRICT_FLAGS_IGNORED/QA_FLAGS_IGNORED, and the tree has been
converted over to the new ones, so drop the old vars.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 bin/misc-functions.sh | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh
index c8b7cc8..55d37f2 100755
--- a/bin/misc-functions.sh
+++ b/bin/misc-functions.sh
@@ -167,8 +167,6 @@ install_qa_check() {
 
 	cd "${ED}" || die "cd failed"
 
-	# Merge QA_FLAGS_IGNORED and QA_DT_HASH into a single array, since
-	# QA_DT_HASH is deprecated.
 	qa_var="QA_FLAGS_IGNORED_${ARCH/-/_}"
 	eval "[[ -n \${!qa_var} ]] && QA_FLAGS_IGNORED=(\"\${${qa_var}[@]}\")"
 	if [[ ${#QA_FLAGS_IGNORED[@]} -eq 1 ]] ; then
@@ -179,29 +177,6 @@ install_qa_check() {
 		set -${shopts}
 	fi
 
-	qa_var="QA_DT_HASH_${ARCH/-/_}"
-	eval "[[ -n \${!qa_var} ]] && QA_DT_HASH=(\"\${${qa_var}[@]}\")"
-	if [[ ${#QA_DT_HASH[@]} -eq 1 ]] ; then
-		local shopts=$-
-		set -o noglob
-		QA_DT_HASH=(${QA_DT_HASH})
-		set +o noglob
-		set -${shopts}
-	fi
-
-	if [[ -n ${QA_DT_HASH} ]] ; then
-		QA_FLAGS_IGNORED=("${QA_FLAGS_IGNORED[@]}" "${QA_DT_HASH[@]}")
-		unset QA_DT_HASH
-	fi
-
-	# Merge QA_STRICT_FLAGS_IGNORED and QA_STRICT_DT_HASH, since
-	# QA_STRICT_DT_HASH is deprecated
-	if [ "${QA_STRICT_FLAGS_IGNORED-unset}" = unset ] && \
-		[ "${QA_STRICT_DT_HASH-unset}" != unset ] ; then
-		QA_STRICT_FLAGS_IGNORED=1
-		unset QA_STRICT_DT_HASH
-	fi
-
 	# Check for files built without respecting *FLAGS. Note that
 	# -frecord-gcc-switches must be in all *FLAGS variables, in
 	# order to avoid false positive results here.
-- 
1.7.12



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] drop support for QA_DT_HASH/QA_STRICT_DT_HASH
  2012-09-24  0:49 [gentoo-portage-dev] [PATCH] drop support for QA_DT_HASH/QA_STRICT_DT_HASH Mike Frysinger
@ 2012-09-24  1:39 ` Zac Medico
  2012-09-24  3:47   ` Mike Frysinger
  0 siblings, 1 reply; 3+ messages in thread
From: Zac Medico @ 2012-09-24  1:39 UTC (permalink / raw
  To: gentoo-portage-dev

On 09/23/2012 05:49 PM, Mike Frysinger wrote:
> These variables have been deprecated in favor of the new variables
> QA_STRICT_FLAGS_IGNORED/QA_FLAGS_IGNORED, and the tree has been
> converted over to the new ones, so drop the old vars.

You can also drop those variables from man/ebuild.5 and make.conf.5, but
otherwise it looks good.
-- 
Thanks,
Zac


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] drop support for QA_DT_HASH/QA_STRICT_DT_HASH
  2012-09-24  1:39 ` Zac Medico
@ 2012-09-24  3:47   ` Mike Frysinger
  0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2012-09-24  3:47 UTC (permalink / raw
  To: gentoo-portage-dev

[-- Attachment #1: Type: Text/Plain, Size: 437 bytes --]

On Sunday 23 September 2012 21:39:45 Zac Medico wrote:
> On 09/23/2012 05:49 PM, Mike Frysinger wrote:
> > These variables have been deprecated in favor of the new variables
> > QA_STRICT_FLAGS_IGNORED/QA_FLAGS_IGNORED, and the tree has been
> > converted over to the new ones, so drop the old vars.
> 
> You can also drop those variables from man/ebuild.5 and make.conf.5, but
> otherwise it looks good.

done & pushed
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-09-24  6:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-24  0:49 [gentoo-portage-dev] [PATCH] drop support for QA_DT_HASH/QA_STRICT_DT_HASH Mike Frysinger
2012-09-24  1:39 ` Zac Medico
2012-09-24  3:47   ` Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox