From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RAgwS-0001By-Lv for garchives@archives.gentoo.org; Mon, 03 Oct 2011 11:44:18 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BE14221C0EE; Mon, 3 Oct 2011 11:44:01 +0000 (UTC) Received: from mail-pz0-f47.google.com (mail-pz0-f47.google.com [209.85.210.47]) by pigeon.gentoo.org (Postfix) with ESMTP id 0BF3D21C0CF for ; Mon, 3 Oct 2011 11:43:47 +0000 (UTC) Received: by pzk4 with SMTP id 4so12303254pzk.6 for ; Mon, 03 Oct 2011 04:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=F+6fyZzgGJKLEURaAuwl4eieSvJrHssiSHQ6fG4Ze/k=; b=ZtpYP0BahFXAL0PnFVLZei+v9xszydVp4fgq4wYaRQp6K5CBN3y+u9frV2O30U6i1Y 9btLwymGWlflve5pF74VftX2KTI3ArttzsVHa1OTE7TuNDUcILXSkZs4PyyVlGGaklJe Vx+0t33tH5D9HGguwc8d+rnOQ0HBEncUJwYEg= Received: by 10.68.34.138 with SMTP id z10mr220002pbi.105.1317642227376; Mon, 03 Oct 2011 04:43:47 -0700 (PDT) Received: from smtp.gmail.com:587 (74-95-192-101-SFBA.hfc.comcastbusiness.net. [74.95.192.101]) by mx.google.com with ESMTPS id z1sm53036010pbl.5.2011.10.03.04.43.45 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 03 Oct 2011 04:43:46 -0700 (PDT) Received: by smtp.gmail.com:587 (sSMTP sendmail emulation); Mon, 03 Oct 2011 04:43:44 -0700 Date: Mon, 3 Oct 2011 04:43:44 -0700 From: Brian Harring To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [GLEP59v2 5/5] GLEP59: Change live Manifest2 hashes to SHA256, SHA512, WHIRLPOOL Message-ID: <20111003114344.GA3849@localhost> References: <1317454855-2794-1-git-send-email-robbat2@gentoo.org> <1317454855-2794-6-git-send-email-robbat2@gentoo.org> <4E87EB2D.6070809@gentoo.org> <4E88CC0D.6080702@gentoo.org> <4E88D331.8060700@gentoo.org> <20111002232242.GB3765@localhost> <4E890013.30706@gentoo.org> <4E898507.90302@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E898507.90302@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Archives-Salt: X-Archives-Hash: f9ecfa06d097331cce834fac033687e3 On Mon, Oct 03, 2011 at 02:48:55AM -0700, Zac Medico wrote: > On 10/02/2011 05:21 PM, Zac Medico wrote: > > On 10/02/2011 04:22 PM, Brian Harring wrote: > >> On Sun, Oct 02, 2011 at 02:10:09PM -0700, Zac Medico wrote: > > I've implemented it with booleans in this commit: > > > > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=c8cd3a985cc529299411d7343a11004b7d1330ef > > > >> Should use a space delimited list instead named hashes instead; those > >> being the hashes that should be generated, and that can be /used/. > >> Not in the list, not an acceptable hash (even if a manifest2 carries > >> that data). > > > > Why? Boolean flags are simpler and they work. > > After some thought, I like the space delimited approach better. Here's > the patch, which retains the ability to remove the manifest hash > settings from layout.conf after they become redundant: > > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=d9d0606fe01618cc81fb0b862ada91149dad3746 Suggest you go through the implementation a bit closer; quick look, if the repo no longer uses what portage considers a required hash (atm, sha1), it still will force it in; while that's rather annoying for manifest creation, the validation logic there strikes me as probably being buggy for that case. ~harring