From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RAVN7-00085m-QP for garchives@archives.gentoo.org; Sun, 02 Oct 2011 23:23:02 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AE3B821C082; Sun, 2 Oct 2011 23:22:51 +0000 (UTC) Received: from mail-yw0-f53.google.com (mail-yw0-f53.google.com [209.85.213.53]) by pigeon.gentoo.org (Postfix) with ESMTP id 6631A21C059 for ; Sun, 2 Oct 2011 23:22:42 +0000 (UTC) Received: by ywt2 with SMTP id 2so4180471ywt.40 for ; Sun, 02 Oct 2011 16:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=xkLaikuckSMPoU7PTEZOV2FUWCapCMi2rOWhBEbE58E=; b=RCbn7uhikwlLmJ4t8blkMMKPqfBUKZmsp/gvy8wx3Ixh6qUh4Rr0ok8DRPFIcfhX7x JBDheeKUWrKDosmZh/dixQexpgo8FCPaQ7o3QZ1U8YbSjyItCzqsEP9x5HtEMvus2RaQ vuZlDtsKIth80TxnUFoijleXYtInmEY+xGnO4= Received: by 10.68.31.4 with SMTP id w4mr47447961pbh.20.1317597761466; Sun, 02 Oct 2011 16:22:41 -0700 (PDT) Received: from smtp.gmail.com:587 (74-95-192-101-SFBA.hfc.comcastbusiness.net. [74.95.192.101]) by mx.google.com with ESMTPS id p4sm12896592pbs.6.2011.10.02.16.22.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 02 Oct 2011 16:22:40 -0700 (PDT) Received: by smtp.gmail.com:587 (sSMTP sendmail emulation); Sun, 02 Oct 2011 16:22:42 -0700 Date: Sun, 2 Oct 2011 16:22:42 -0700 From: Brian Harring To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [GLEP59v2 5/5] GLEP59: Change live Manifest2 hashes to SHA256, SHA512, WHIRLPOOL Message-ID: <20111002232242.GB3765@localhost> References: <1317454855-2794-1-git-send-email-robbat2@gentoo.org> <1317454855-2794-6-git-send-email-robbat2@gentoo.org> <4E87EB2D.6070809@gentoo.org> <4E88CC0D.6080702@gentoo.org> <4E88D331.8060700@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E88D331.8060700@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Archives-Salt: X-Archives-Hash: b5578654a19832ac3d443781188cdc5d On Sun, Oct 02, 2011 at 02:10:09PM -0700, Zac Medico wrote: > On 10/02/2011 01:54 PM, Robin H. Johnson wrote: > > On Sun, Oct 02, 2011 at 01:39:41PM -0700, Zac Medico wrote: > >> On 10/02/2011 05:46 AM, Robin H. Johnson wrote: > >>> On Sat, Oct 01, 2011 at 09:40:13PM -0700, Zac Medico wrote: > >>>> If we control these hashes via metadata/layout.conf, then we can toggle > >>>> it atomically for all commiters. Otherwise, we'll have an annoying > >>>> period of time where different committers are committing different sets > >>>> of hashes, depending on their portage version. > >>> How do you suggest doing it via layout.conf? I've kept SHA256 in both > >>> sets for now, but if you could enforce new signatures including both > >>> WHIRLPOOL and SHA256, that would be great. > >> How about if we put something like this in > >> gentoo-x86/metadata/layout.conf now: > > Did you mean profiles/layout.conf? I just want to make sure no scripts > > that pull from CVS and expect that dir to not exist don't break. > > No, it's metadata/layout.conf. I didn't choose the location. We actually > inherited it from paludis about 1.5 years ago: > > > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=f16aee82cefa95e9903fa46f448d30f6d4350f64 > > We're also using it to control thin-manifest support, among other things > now: > > https://bugs.gentoo.org/show_bug.cgi?id=333691 > > >> manifest2-sha1 = true > >> manifest2-whirlpool = false > > Bikeshedding slightly, but can we figure something like a list or dict > > instead? (Also gives us a chance to make the required hashes a list). > > manifest2-hashes = ['SHA1', 'SHA256', 'RMD160'] > > Well, booleans are simpler. Also, note that I designed them to be > removed from layout.conf eventually, which means that we will accumulate > less bloat in layout.conf over time. Should use a space delimited list instead named hashes instead; those being the hashes that should be generated, and that can be /used/. Not in the list, not an acceptable hash (even if a manifest2 carries that data). If it's not set, then the pm defaults in a list; that default list should be tracked somewhere (rather than just whatever the PM author decides) also, although that's a seperate discussion. Breaking it out into individual booleans isn't particularly great; we use lists for masters, a tristate for use-manifest, etc. Having each CHF controlled by a seperate boolean adds more toggles than is worth it imo, and having the manifest2- prefix makes the parsing slightly more complex while also making the key name a bit daft if we ever switch to a manifest3. ;) ~harring