From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.50) id 1EVoU4-00045n-43 for garchives@archives.gentoo.org; Sat, 29 Oct 2005 11:02:48 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.5/8.13.5) with SMTP id j9TB2D4m012817; Sat, 29 Oct 2005 11:02:13 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [134.68.220.30]) by robin.gentoo.org (8.13.5/8.13.5) with ESMTP id j9TB2C9C004698 for ; Sat, 29 Oct 2005 11:02:13 GMT Received: from zh034158.ppp.dion.ne.jp ([222.3.34.158] helo=opteron246.suzuki-stubbs.home) by smtp.gentoo.org with esmtpa (Exim 4.43) id 1EVoTU-0001rv-Gy for gentoo-portage-dev@lists.gentoo.org; Sat, 29 Oct 2005 11:02:12 +0000 Received: by opteron246.suzuki-stubbs.home (Postfix, from userid 1000) id 1BFC2248ADB; Sat, 29 Oct 2005 20:03:17 +0900 (JST) From: Jason Stubbs To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [4/7] portage_exec cleanups Date: Sat, 29 Oct 2005 20:03:16 +0900 User-Agent: KMail/1.8.92 References: <200510231545.16596.jstubbs@gentoo.org> <200510291934.13207.jstubbs@gentoo.org> <200510291952.57471.jstubbs@gentoo.org> In-Reply-To: <200510291952.57471.jstubbs@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510292003.16994.jstubbs@gentoo.org> X-Archives-Salt: 7c1922dc-b8a9-4a89-8255-8890cced1230 X-Archives-Hash: 0733f8889eda60524f90879a9426beee On Saturday 29 October 2005 19:52, Jason Stubbs wrote: > Remove the exit status check from the logging's setup code and allow it to > be handled by the final process monitoring loop. This adds slight overhead > of unnecessarily setting up ebuild when tee is broken but simplifies the > code. > > Closing of the read end of the pipe is also moved to just after tee has > been spawned so that it is not incorrectly left open in the ebuild process. Forgot to mention here that the write end of the pipe is passed to tee's spawn() so that tee's process doesn't keep the write pipe left open causing it to never exit. -- gentoo-portage-dev@gentoo.org mailing list