From: Jason Stubbs <jstubbs@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] Ignore blockers when fetching and using --ask
Date: Tue, 27 Sep 2005 15:36:44 +0900 [thread overview]
Message-ID: <200509271536.44010.jstubbs@gentoo.org> (raw)
In-Reply-To: <200509271520.05347.jstubbs@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
While not harmful, there was one issue with the previous patch; the parent of
the blocking package would be fetched as well. This would usually mean that
one of the packages being merged would be fetched twice. This patch fixes
that.
[-- Attachment #2: ignore-blockers-on-fetch.patch --]
[-- Type: text/x-diff, Size: 1138 bytes --]
diff -uNr 2.0/bin/emerge 2.0-patched/bin/emerge
--- 2.0/bin/emerge 2005-09-27 13:16:09.000000000 +0900
+++ 2.0-patched/bin/emerge 2005-09-27 15:34:03.000000000 +0900
@@ -3173,7 +3173,7 @@
if x[3]!="nomerge":
mergecount+=1
#check for blocking dependencies
- if x[0]=="blocks":
+ if x[0]=="blocks" and "--fetchonly" not in myopts and "--fetch-all-uri" not in myopts:
print "\n!!! Error: The above package list contains packages which cannot be installed"
print "!!! on the same system."
print
@@ -3224,7 +3224,14 @@
y=portage.portdb.findname(pkgline[2])
tmpsettings = portage.config(clone=portage.settings)
retval=portage.doebuild(y,"digest",portage.root,tmpsettings,edebug,("--pretend" in myopts))
- mydepgraph.merge(mydepgraph.altlist())
+ if "--fetchonly" in myopts or "--fetch-all-uri" in myopts:
+ pkglist = []
+ for pkg in mydepgraph.altlist():
+ if pkg[0] != "blocks":
+ pkglist.append(pkg)
+ else:
+ pkglist = mydepgraph.altlist()
+ mydepgraph.merge(pkglist)
if portage.mtimedb.has_key("resume"):
del portage.mtimedb["resume"]
prev parent reply other threads:[~2005-09-27 6:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 6:20 [gentoo-portage-dev] [PATCH] Ignore blockers when fetching and using --ask Jason Stubbs
2005-09-27 6:36 ` Jason Stubbs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509271536.44010.jstubbs@gentoo.org \
--to=jstubbs@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox