From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.43) id 1Dvkng-0007up-JJ for garchives@archives.gentoo.org; Thu, 21 Jul 2005 23:50:01 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.4/8.13.4) with SMTP id j6LNn6vW017862; Thu, 21 Jul 2005 23:49:06 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [134.68.220.30]) by robin.gentoo.org (8.13.4/8.13.4) with ESMTP id j6LNn54L027743 for ; Thu, 21 Jul 2005 23:49:06 GMT Received: from p061198163122.ppp.prin.ne.jp ([61.198.163.122] helo=opteron246.suzuki-stubbs.home) by smtp.gentoo.org with esmtpa (Exim 4.43) id 1Dvkn8-00082e-AX for gentoo-portage-dev@lists.gentoo.org; Thu, 21 Jul 2005 23:49:28 +0000 Received: by opteron246.suzuki-stubbs.home (Postfix, from userid 1000) id 0431B1032EF; Fri, 22 Jul 2005 08:49:43 +0900 (JST) From: Jason Stubbs To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] PATCH: Use lchown and lchgrp no-op functions when operating on symlinks (#99616) Date: Fri, 22 Jul 2005 08:49:41 +0900 User-Agent: KMail/1.8.1 References: <200507212313.36804.jstubbs@gentoo.org> <20050721171701.GA27660@exodus> In-Reply-To: <20050721171701.GA27660@exodus> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1776263.BEVCb7Zunf"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200507220849.43700.jstubbs@gentoo.org> X-Archives-Salt: 5351be98-6c8f-4352-b772-a538edfb0511 X-Archives-Hash: 9fcd09a3742e7d1787f1b19ddbe7a2f3 --nextPart1776263.BEVCb7Zunf Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 22 July 2005 02:17, Brian D. Harring wrote: > On Thu, Jul 21, 2005 at 11:13:34PM +0900, Jason Stubbs wrote: > > diff -uNr portage-2.0.51.22-r2/bin/ebuild.sh portage-patched/bin/ebuild= =2Esh > > --- portage-2.0.51.22-r2/bin/ebuild.sh 2005-07-19 19:38:32.949904000 +0= 900 > > +++ portage-patched/bin/ebuild.sh 2005-07-21 23:03:58.429898000 +0900 > > @@ -85,6 +85,11 @@ > > export SANDBOX_PREDICT=3D"$SANDBOX_PREDICT:$1" > > } > > =20 > > +lchown() > > +{ 0; } > > + > > +lchgrp() > > +{ 0; } > > Default being negation of funcs, and forcing profiles to override it? > Why not reverse it, a default func that works, with profiles=20 > overriding if/when it doesn't work? I don't really like the idea of adding yet another >& /dev/null. With a GNU userland, it would be something like: lchown() { chown -h $* } If the many errors that will occur when the userland's chown doesn't support this flag are okay, putting in working defaults are fine. The main reasons I went with no-ops are that symlink ownership is purely cosmetic (afaik) and to try to keep userland specific stuff out. =2D-=20 Jason Stubbs --nextPart1776263.BEVCb7Zunf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQBC4DSXxvWNPsk/ZP4RAvCPAJ9Ihwq+LULSd2KC4EfOo5EompUSvACfbsz1 LU3Im07Y7wLbN2mi/E01ta8= =LECh -----END PGP SIGNATURE----- --nextPart1776263.BEVCb7Zunf-- -- gentoo-portage-dev@gentoo.org mailing list