Re: [gentoo-portage-dev] PATCH: Use lchown and lchgrp no-op functions when operating on symlinks (#99616)

[Jason Stubbs <jstubbs@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

On Friday 22 July 2005 02:17, Brian D. Harring wrote:
> On Thu, Jul 21, 2005 at 11:13:34PM +0900, Jason Stubbs wrote:
> > diff -uNr portage-2.0.51.22-r2/bin/ebuild.sh portage-patched/bin/ebuild.sh
> > --- portage-2.0.51.22-r2/bin/ebuild.sh	2005-07-19 19:38:32.949904000 +0900
> > +++ portage-patched/bin/ebuild.sh	2005-07-21 23:03:58.429898000 +0900
> > @@ -85,6 +85,11 @@
> >  	export SANDBOX_PREDICT="$SANDBOX_PREDICT:$1"
> >  }
> >  
> > +lchown()
> > +{ 0; }
> > +
> > +lchgrp()
> > +{ 0; }
>
> Default being negation of funcs, and forcing profiles to override it?
> Why not reverse it, a default func that works, with profiles 
> overriding if/when it doesn't work?

I don't really like the idea of adding yet another >& /dev/null. With a GNU
userland, it would be something like:

lchown()
{ chown -h $* }

If the many errors that will occur when the userland's chown doesn't support
this flag are okay, putting in working defaults are fine. The main reasons I
went with no-ops are that symlink ownership is purely cosmetic (afaik) and
to try to keep userland specific stuff out.

-- 
Jason Stubbs

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]