From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.43) id 1DuM52-0000AP-M7 for garchives@archives.gentoo.org; Mon, 18 Jul 2005 03:14:09 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.4/8.13.4) with SMTP id j6I3CqWr002024; Mon, 18 Jul 2005 03:12:52 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [134.68.220.30]) by robin.gentoo.org (8.13.4/8.13.4) with ESMTP id j6I3Cps4020591 for ; Mon, 18 Jul 2005 03:12:51 GMT Received: from p061204002040.ppp.prin.ne.jp ([61.204.2.40] helo=opteron246.suzuki-stubbs.home) by smtp.gentoo.org with esmtpa (Exim 4.43) id 1DuM4P-0006il-Ll for gentoo-portage-dev@lists.gentoo.org; Mon, 18 Jul 2005 03:13:33 +0000 Received: by opteron246.suzuki-stubbs.home (Postfix, from userid 1000) id BCCEF100A8E; Mon, 18 Jul 2005 12:13:41 +0900 (JST) From: Jason Stubbs To: gentoo-portage-dev@lists.gentoo.org Subject: [gentoo-portage-dev] PATCH: Make lchown a no-op rather than aliasing to chown on Darwin (#98827) Date: Mon, 18 Jul 2005 12:13:39 +0900 User-Agent: KMail/1.8.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4321949.rs0QAP0T1H"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200507181213.41595.jstubbs@gentoo.org> X-Archives-Salt: a62d8e6f-8f8f-4f8d-b7b4-b70920065ca4 X-Archives-Hash: 7251d474321ebd1120dbe4a63523565c --nextPart4321949.rs0QAP0T1H Content-Type: multipart/mixed; boundary="Boundary-01=_j5x2CxDwsVNZHzP" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-01=_j5x2CxDwsVNZHzP Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline http://bugs.gentoo.org/show_bug.cgi?id=3D98827 Author: Jason Stubbs Portage presently alters permissions of the target of a symlink rather=20 than the symlink itself on Darwin. As well as the possibility that=20 the target's permissions are modified incorrectly, there is also the=20 case that the symlink points somewhere on the live filesystem or=20 doesn't point anywhere at all. The former case will is definately=20 incorrect and the latter case will cause portage to fail with a=20 traceback. Making lchown a no-op should fix all these cases without=20 any regressions. =2D-=20 Jason Stubbs --Boundary-01=_j5x2CxDwsVNZHzP Content-Type: text/x-diff; charset="us-ascii"; name="98827_darwin_noop_lchown.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="98827_darwin_noop_lchown.patch" diff -uNr portage-stable/pym/portage_data.py portage-fixed/pym/portage_data= =2Epy =2D-- portage-stable/pym/portage_data.py 2005-05-15 19:20:58.000000000 +0900 +++ portage-fixed/pym/portage_data.py 2005-07-18 11:27:09.096800056 +0900 @@ -16,8 +16,9 @@ os.environ["XARGS"]=3D"xargs -r" elif ostype =3D=3D "Darwin": userland=3D"Darwin" =2D os.environ["XARGS"]=3D"xargs"=09 =2D lchown=3Dos.chown + os.environ["XARGS"]=3D"xargs" + def lchown(*pos_args, **key_args): + pass elif ostype in ["FreeBSD","OpenBSD"]: userland=3D"BSD" os.environ["XARGS"]=3D"xargs" --Boundary-01=_j5x2CxDwsVNZHzP-- --nextPart4321949.rs0QAP0T1H Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQBC2x5lxvWNPsk/ZP4RAoo/AJ9EEl3L3QqwTUd6lJmZ6i8BGxNjygCghGBg Lx+42cmX7U6OQ1aBqp8Uy70= =jCUM -----END PGP SIGNATURE----- --nextPart4321949.rs0QAP0T1H-- -- gentoo-portage-dev@gentoo.org mailing list