From: Jason Stubbs <jstubbs@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: [gentoo-portage-dev] PATCH: Make lchown a no-op rather than aliasing to chown on Darwin (#98827)
Date: Mon, 18 Jul 2005 12:13:39 +0900 [thread overview]
Message-ID: <200507181213.41595.jstubbs@gentoo.org> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 595 bytes --]
http://bugs.gentoo.org/show_bug.cgi?id=98827
Author: Jason Stubbs
Portage presently alters permissions of the target of a symlink rather
than the symlink itself on Darwin. As well as the possibility that
the target's permissions are modified incorrectly, there is also the
case that the symlink points somewhere on the live filesystem or
doesn't point anywhere at all. The former case will is definately
incorrect and the latter case will cause portage to fail with a
traceback. Making lchown a no-op should fix all these cases without
any regressions.
--
Jason Stubbs
[-- Attachment #1.2: 98827_darwin_noop_lchown.patch --]
[-- Type: text/x-diff, Size: 550 bytes --]
diff -uNr portage-stable/pym/portage_data.py portage-fixed/pym/portage_data.py
--- portage-stable/pym/portage_data.py 2005-05-15 19:20:58.000000000 +0900
+++ portage-fixed/pym/portage_data.py 2005-07-18 11:27:09.096800056 +0900
@@ -16,8 +16,9 @@
os.environ["XARGS"]="xargs -r"
elif ostype == "Darwin":
userland="Darwin"
- os.environ["XARGS"]="xargs"
- lchown=os.chown
+ os.environ["XARGS"]="xargs"
+ def lchown(*pos_args, **key_args):
+ pass
elif ostype in ["FreeBSD","OpenBSD"]:
userland="BSD"
os.environ["XARGS"]="xargs"
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2005-07-18 3:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-18 3:13 Jason Stubbs [this message]
2005-07-19 14:27 ` [gentoo-portage-dev] PATCH: Only use lchown on symlinks (#98827) Jason Stubbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200507181213.41595.jstubbs@gentoo.org \
--to=jstubbs@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox