Re: Fwd: [gentoo-portage-dev] [PATCH v2] Support PORTAGE_LOG_FILTER_FILE (bug 709746)

Re: Fwd: [gentoo-portage-dev] [PATCH v2] Support PORTAGE_LOG_FILTER_FILE (bug 709746)

[Zac Medico]

[-- Attachment #1.1: Type: text/plain, Size: 1237 bytes --]

On 3/2/20 10:33 PM, Michael 'veremitz' Everitt wrote:
>> diff --git a/man/make.conf.5 b/man/make.conf.5
>> index f82fed65a..69bfa6cdf 100644
>> --- a/man/make.conf.5
>> +++ b/man/make.conf.5
>> @@ -979,6 +979,10 @@ with an integer pid. For example, a value of "ionice \-c 3 \-p \\${PID}"
>>  will set idle io priority. For more information about ionice, see
>>  \fBionice\fR(1). This variable is unset by default.
>>  .TP
>> +.B PORTAGE_LOG_FILTER_FILE
>> +This variable specifies a command that filters build log output to a
>> +log file.
>> +.TP
>>  .B PORTAGE_LOGDIR
>>  This variable defines the directory in which per\-ebuild logs are kept.
>>  Logs are created only when this is set. They are stored as
> 
> I'm somewhat confused by the variable name "PORTAGE_LOG_FILTER_FILE" - the
> suffix of 'file' suggests it references a file rather than the command I
> believe we're intending - perhaps "PORTAGE_LOG_FILE_FILTER_CMD" may be more
> explicit?

Yes, I agree. Renamed:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=e24859eaa03ec86e10d842296f5570dd98bed4b7


> Perhaps the feature name/bug also needs tweaking to reflect this.
> 
> Otherwise, looks very promising!


-- 
Thanks,
Zac


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]