public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org, James Le Cuirot <chewi@gentoo.org>
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH] Allow ESYSROOT and BROOT in the pkg_setup phase
Date: Tue, 13 Aug 2019 18:42:05 -0700	[thread overview]
Message-ID: <1ae10638-a10b-9ac5-e2eb-09b152b6e5d5@gentoo.org> (raw)
In-Reply-To: <20190811135134.28917-1-chewi@gentoo.org>


[-- Attachment #1.1: Type: text/plain, Size: 1385 bytes --]

On 8/11/19 6:51 AM, James Le Cuirot wrote:
> From: Michał Górny <mgorny@gentoo.org>
> 
> This follows a recent change to PMS.
> 
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
>  lib/portage/package/ebuild/config.py | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Sending this on behalf of mgorny as requested.
> 
> diff --git a/lib/portage/package/ebuild/config.py b/lib/portage/package/ebuild/config.py
> index 83a15b370..e0dda54d4 100644
> --- a/lib/portage/package/ebuild/config.py
> +++ b/lib/portage/package/ebuild/config.py
> @@ -2820,12 +2820,13 @@ class config(object):
>  		if not eapi_exports_merge_type(eapi):
>  			mydict.pop("MERGE_TYPE", None)
>  
> -		src_phase = _phase_func_map.get(phase, '').startswith('src_')
> +		src_like_phase = (phase == 'setup' or
> +				_phase_func_map.get(phase, '').startswith('src_'))
>  
> -		if not (src_phase and eapi_attrs.sysroot):
> +		if not (src_like_phase and eapi_attrs.sysroot):
>  			mydict.pop("ESYSROOT", None)
>  
> -		if not (src_phase and eapi_attrs.broot):
> +		if not (src_like_phase and eapi_attrs.broot):
>  			mydict.pop("BROOT", None)
>  
>  		# Prefix variables are supported beginning with EAPI 3, or when
> 

Thanks, merged:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=f28d32f298d4b089a2e36bebca2a55b6aeabe2a3
-- 
Thanks,
Zac


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

      reply	other threads:[~2019-08-14  1:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-11 13:51 [gentoo-portage-dev] [PATCH] Allow ESYSROOT and BROOT in the pkg_setup phase James Le Cuirot
2019-08-14  1:42 ` Zac Medico [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ae10638-a10b-9ac5-e2eb-09b152b6e5d5@gentoo.org \
    --to=zmedico@gentoo.org \
    --cc=chewi@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    --cc=mgorny@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox