From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 43341138334 for ; Mon, 7 Jan 2019 19:05:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CB45FE09D7; Mon, 7 Jan 2019 19:05:37 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 97665E09D7 for ; Mon, 7 Jan 2019 19:05:37 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id B1781335D06; Mon, 7 Jan 2019 19:05:35 +0000 (UTC) Message-ID: <1546887921.860.16.camel@gentoo.org> Subject: Re: [gentoo-portage-dev] [PATCH] lib/portage/dbapi/vartree: use dynamic report interval in _collision_protect From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-portage-dev@lists.gentoo.org Cc: Fabian Groffen Date: Mon, 07 Jan 2019 20:05:21 +0100 In-Reply-To: <20190107143113.7068-1-grobian@gentoo.org> References: <20190107143113.7068-1-grobian@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-11N8lwbgyACTzVp/yfSz" X-Mailer: Evolution 3.26.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply Mime-Version: 1.0 X-Archives-Salt: a2155723-063c-4858-90fc-183fe79d067b X-Archives-Hash: 6007024d46c7ead969e67bd7487056ce --=-11N8lwbgyACTzVp/yfSz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2019-01-07 at 15:31 +0100, Fabian Groffen wrote: > The reporting of files remaining can look somewhat odd since the report > interval is hardcoded to be per 1000 objects. Adjust this interval to > be regular towards the end. While at it, report percentage done. >=20 > Output before this patch: >=20 > * checking 6111 files for package collisions > 5111 files remaining ... > 4111 files remaining ... > 3111 files remaining ... > 2111 files remaining ... > 1111 files remaining ... > 111 files remaining ... >=20 > After: >=20 > * checking 6158 files for package collisions > 16% done, 5131 files remaining ... > 33% done, 4104 files remaining ... > 50% done, 3077 files remaining ... > 66% done, 2050 files remaining ... > 83% done, 1023 files remaining ... >=20 Not saying it's necessary but could we have some final message here? I find it a bit weird to end at 83%. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-11N8lwbgyACTzVp/yfSz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEXr8g+Zb7PCLMb8pAur8dX/jIEQoFAlwzovFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDVF QkYyMEY5OTZGQjNDMjJDQzZGQ0E0MEJBQkYxRDVGRjhDODExMEEACgkQur8dX/jI EQq3pg//S3U0yawi+xW71HjiH5I5upjpExDcshM3QURL1ev39dMnQNajkah/5LUj tSJDLEz50/IpfAIe+S9WCFnaiiq2S97vTsUYO1VMM3/MfQwByy1goovYwzHhLR4i UAXXj/4CguaW4qBGy3aEvMofutUPolrCRJ7Svuu4fJ+LndbcmuKUKlONQL2QX0Lj 8Vf2j08pPHqOqa0eVBGihWYTMBQkvUjBiKtobjECwt7OH2iO3TzTztAPW+4Og4O6 Z296Lbf06uMlhbt7iEX2mbMEITHy+QsCc6oQePHEiWlPX4ybDXwQA6UjXpLQc4Oh kKWuAJRnxhDzwHcPku4UGF3yQqeChUTtyGvKzDT9ppqQmF4X28u/26TpKCn7xLvQ q2gST71OzHEin671Oi1ptSZqKTOqoVxcFZYzs3lcFDkPh+807tS3CPeL4sS5zIxi c8Z7gtf2O2bwbG+Na03Q2HK7CJB8gEpXaKCw96T6ZnKsd8dLGp+iqU2vOxtAE9AH gbFoTXEeDo7IRDRcYkRqKTQC/stkEptevv7WsyuhXW1scpRZ8RfJF1mdpF6Mi8Ga fPpTpExcZd04b0mZpf9tRJb5Jdhq1YwbonaIYvA7m4Kwv8AZg8rqxLDGb9foLfiJ bKoIdrw7hAdWg/2oju5Uj8pSBj2o3s4jmGUWCMnqbdUm4MuyiZY= =NoWr -----END PGP SIGNATURE----- --=-11N8lwbgyACTzVp/yfSz--