From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: Fabian Groffen <grobian@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH] lib/portage/dbapi/vartree: use dynamic report interval in _collision_protect
Date: Mon, 07 Jan 2019 20:05:21 +0100 [thread overview]
Message-ID: <1546887921.860.16.camel@gentoo.org> (raw)
In-Reply-To: <20190107143113.7068-1-grobian@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Mon, 2019-01-07 at 15:31 +0100, Fabian Groffen wrote:
> The reporting of files remaining can look somewhat odd since the report
> interval is hardcoded to be per 1000 objects. Adjust this interval to
> be regular towards the end. While at it, report percentage done.
>
> Output before this patch:
>
> * checking 6111 files for package collisions
> 5111 files remaining ...
> 4111 files remaining ...
> 3111 files remaining ...
> 2111 files remaining ...
> 1111 files remaining ...
> 111 files remaining ...
>
> After:
>
> * checking 6158 files for package collisions
> 16% done, 5131 files remaining ...
> 33% done, 4104 files remaining ...
> 50% done, 3077 files remaining ...
> 66% done, 2050 files remaining ...
> 83% done, 1023 files remaining ...
>
Not saying it's necessary but could we have some final message here?
I find it a bit weird to end at 83%.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2019-01-07 19:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 14:31 [gentoo-portage-dev] [PATCH] lib/portage/dbapi/vartree: use dynamic report interval in _collision_protect Fabian Groffen
2019-01-07 18:54 ` Zac Medico
2019-01-07 19:05 ` Michał Górny [this message]
2019-01-08 8:09 ` [gentoo-portage-dev] [PATCH] collision_protect: use dynamic report interval Fabian Groffen
2019-01-08 8:17 ` Ulrich Mueller
2019-01-08 8:18 ` Fabian Groffen
2019-01-08 13:42 ` [gentoo-portage-dev] [PATCH v3] " Fabian Groffen
2019-01-08 19:15 ` Zac Medico
2019-01-08 20:59 ` M. J. Everitt
2019-01-09 8:09 ` Fabian Groffen
2019-01-09 8:33 ` [gentoo-portage-dev] [PATCH v4] " Fabian Groffen
2019-01-10 5:22 ` Zac Medico
2019-01-10 8:22 ` Fabian Groffen
2019-01-10 15:30 ` [gentoo-portage-dev] [PATCH v5] " Fabian Groffen
2019-01-11 4:37 ` Zac Medico
2019-01-11 10:16 ` Fabian Groffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546887921.860.16.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=grobian@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox