From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8E039138330 for ; Sun, 25 Sep 2016 01:49:47 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DD096E0C23; Sun, 25 Sep 2016 01:49:44 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3C632E0C21 for ; Sun, 25 Sep 2016 01:49:44 +0000 (UTC) Received: from 11e.gaikai.biz (ip68-5-185-102.oc.oc.cox.net [68.5.185.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 1AA01340A15; Sun, 25 Sep 2016 01:49:43 +0000 (UTC) From: Zac Medico To: gentoo-portage-dev@lists.gentoo.org Cc: Zac Medico Subject: [gentoo-portage-dev] [PATCH] ebuild.sh: start phases in temporary HOME if available (bug 595028) Date: Sat, 24 Sep 2016 18:49:18 -0700 Message-Id: <1474768158-16104-1-git-send-email-zmedico@gentoo.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org X-Archives-Salt: 79dcb0cf-fb3a-4845-9b02-cc30929d0a96 X-Archives-Hash: 61e44b4b2e62dd9e4449aac504219447 This will avoid undesirable interactions with the python sitedir, as reported in bug 574002. Since the temporary HOME is not guaranteed to exist for some phases, use PORTAGE_PYM_PATH as a fallback. Also, use PORTAGE_PYM_PATH inside __dyn_clean, since HOME is removed there. X-Gentoo-Bug: 595028 X-Gentoo-Bug-URL: https://bugs.gentoo.org/595028 --- bin/ebuild.sh | 11 ++++++++--- bin/phase-functions.sh | 8 +++++--- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/bin/ebuild.sh b/bin/ebuild.sh index 5b3146d..4a431b4 100755 --- a/bin/ebuild.sh +++ b/bin/ebuild.sh @@ -167,9 +167,14 @@ export SANDBOX_ON=0 # Ensure that $PWD is sane whenever possible, to protect against # exploitation of insecure search path for python -c in ebuilds. -# See bug #239560 and bug #469338. -cd "${PORTAGE_PYM_PATH}" || \ - die "PORTAGE_PYM_PATH does not exist: '${PORTAGE_PYM_PATH}'" +# See bug #239560, bug #469338, and bug #595028. +if [[ -d ${HOME} ]] then + # Use portage's temporary HOME directory if available. + cd "${HOME}" || die +else + cd "${PORTAGE_PYM_PATH}" || \ + die "PORTAGE_PYM_PATH does not exist: '${PORTAGE_PYM_PATH}'" +fi #if no perms are specified, dirs/files will have decent defaults #(not secretive, but not stupid) diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh index d75f43f..50f0fdb 100644 --- a/bin/phase-functions.sh +++ b/bin/phase-functions.sh @@ -261,6 +261,11 @@ __dyn_clean() { chflags -R nosunlnk,nouunlnk "${PORTAGE_BUILDDIR}" 2>/dev/null fi + # Some kernels, such as Solaris, return EINVAL when an attempt + # is made to remove the current working directory. + cd "${PORTAGE_PYM_PATH}" || \ + die "PORTAGE_PYM_PATH does not exist: '${PORTAGE_PYM_PATH}'" + rm -rf "${PORTAGE_BUILDDIR}/image" "${PORTAGE_BUILDDIR}/homedir" rm -f "${PORTAGE_BUILDDIR}/.installed" @@ -288,9 +293,6 @@ __dyn_clean() { # result in it wiping the users distfiles directory (bad). rm -rf "${PORTAGE_BUILDDIR}/distdir" - # Some kernels, such as Solaris, return EINVAL when an attempt - # is made to remove the current working directory. - cd "$PORTAGE_BUILDDIR"/../.. rmdir "$PORTAGE_BUILDDIR" 2>/dev/null true -- 2.7.4