From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8AF00138222 for ; Wed, 4 May 2016 07:51:49 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0E16E21C12B; Wed, 4 May 2016 07:51:39 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8CF2221C12A for ; Wed, 4 May 2016 07:51:38 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EEDFE20AB1 for ; Wed, 4 May 2016 03:51:37 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 04 May 2016 03:51:37 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=YTHeBY2V13pFGHPN6MVHabjl1Q4=; b=icjMc bxds7GuMeBHRMI+jRRmEfqqPTKNHzsu7skn5RbKPDB9E8+s47l4N/CXh4fA+bKpQ jhlagcjcecXRthSrQ81wNnzPKrt32pGjQpmUGb5JgNgx91zS7ivfnK9QZGS9m7GZ chabsdVI1uOcSYs/CyrhNHQ3iJbbR1c3Ezfw2Y= X-Sasl-enc: 246M5uqTXbl9qmwBYZeTjgGAdrEHaFftE6zZXUtIk4MY 1462348297 Received: from localhost.localdomain (cpe-66-24-84-54.stny.res.rr.com [66.24.84.54]) by mail.messagingengine.com (Postfix) with ESMTPA id A6EC4680270 for ; Wed, 4 May 2016 03:51:37 -0400 (EDT) From: =?UTF-8?q?G=C3=B6kt=C3=BCrk=20Y=C3=BCksek?= To: gentoo-portage-dev@lists.gentoo.org Subject: [gentoo-portage-dev] [PATCH] repoman: include HOME in the variable.readonly check Date: Wed, 4 May 2016 03:51:27 -0400 Message-Id: <1462348287-5645-1-git-send-email-gokturk@binghamton.edu> X-Mailer: git-send-email 2.7.3 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 49cbdc42-1917-4fbe-8c92-b9453644bb84 X-Archives-Hash: 053212f1c850a0469bcc52956c557948 According to the PMS section 11.1, HOME is a read-only variable. Include it in the list of read-only variables for the variable.readonly check in repoman. Signed-off-by: Göktürk Yüksek --- pym/repoman/modules/scan/ebuild/checks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pym/repoman/modules/scan/ebuild/checks.py b/pym/repoman/modules/scan/ebuild/checks.py index 8cdc230..5833d42 100644 --- a/pym/repoman/modules/scan/ebuild/checks.py +++ b/pym/repoman/modules/scan/ebuild/checks.py @@ -236,7 +236,7 @@ class EbuildAssignment(LineCheck): """Ensure ebuilds don't assign to readonly variables.""" repoman_check_name = 'variable.readonly' - read_only_vars = 'A|CATEGORY|P|P[VNRF]|PVR|D|WORKDIR|FILESDIR|FEATURES|USE' + read_only_vars = 'A|CATEGORY|P|P[VNRF]|PVR|D|WORKDIR|FILESDIR|FEATURES|USE|HOME' readonly_assignment = re.compile(r'^\s*(export\s+)?(%s)=' % read_only_vars) def check(self, num, line): -- 2.7.3