From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete
Date: Thu, 12 Nov 2015 16:00:55 +0100 [thread overview]
Message-ID: <1447340455-10961-1-git-send-email-mgorny@gentoo.org> (raw)
Since thick Manifests can reference other files (ChangeLogs especially),
their generation should be run as the lask task done by egencache,
followed only by timestamp update.
---
bin/egencache | 46 +++++++++++++++++++++++-----------------------
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/bin/egencache b/bin/egencache
index 51d115a..e02c690 100755
--- a/bin/egencache
+++ b/bin/egencache
@@ -1095,29 +1095,6 @@ def egencache_main(args):
else:
ret.append(gen_cache.returncode)
- if options.update_manifests:
-
- cp_iter = None
- if atoms:
- cp_iter = iter(atoms)
-
- event_loop = global_event_loop()
- scheduler = ManifestScheduler(portdb, cp_iter=cp_iter,
- gpg_cmd=gpg_cmd, gpg_vars=gpg_vars,
- force_sign_key=force_sign_key,
- max_jobs=options.jobs,
- max_load=options.load_average,
- event_loop=event_loop)
-
- signum = run_main_scheduler(scheduler)
- if signum is not None:
- sys.exit(128 + signum)
-
- if options.tolerant:
- ret.append(os.EX_OK)
- else:
- ret.append(scheduler.returncode)
-
if options.update_pkg_desc_index:
if repo_config.writable:
writable_location = repo_config.location
@@ -1153,6 +1130,29 @@ def egencache_main(args):
gen_clogs.run()
ret.append(gen_clogs.returncode)
+ if options.update_manifests:
+
+ cp_iter = None
+ if atoms:
+ cp_iter = iter(atoms)
+
+ event_loop = global_event_loop()
+ scheduler = ManifestScheduler(portdb, cp_iter=cp_iter,
+ gpg_cmd=gpg_cmd, gpg_vars=gpg_vars,
+ force_sign_key=force_sign_key,
+ max_jobs=options.jobs,
+ max_load=options.load_average,
+ event_loop=event_loop)
+
+ signum = run_main_scheduler(scheduler)
+ if signum is not None:
+ sys.exit(128 + signum)
+
+ if options.tolerant:
+ ret.append(os.EX_OK)
+ else:
+ ret.append(scheduler.returncode)
+
if options.write_timestamp:
timestamp_path = os.path.join(repo_path, 'metadata', 'timestamp.chk')
try:
--
2.6.3
next reply other threads:[~2015-11-12 15:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 15:00 Michał Górny [this message]
2015-11-12 16:35 ` [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete Zac Medico
2015-11-12 16:56 ` Zac Medico
2015-11-12 18:38 ` Brian Dolbec
2015-11-13 12:17 ` Alexander Berntsen
2015-11-13 20:25 ` [gentoo-portage-dev] " Duncan
2015-11-13 21:01 ` Zac Medico
2015-11-16 10:33 ` Alexander Berntsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447340455-10961-1-git-send-email-mgorny@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox