public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: Zac Medico <zmedico@gentoo.org>
Subject: [gentoo-portage-dev] [PATCH v2] repoman: ignore unadded files when possible (bug 559636)
Date: Sat,  5 Sep 2015 07:31:27 -0700	[thread overview]
Message-ID: <1441463487-4101-1-git-send-email-zmedico@gentoo.org> (raw)
In-Reply-To: <1441462844-3288-1-git-send-email-zmedico@gentoo.org>

Unadded files that are excluded from the Manifest are safe to ignore.

X-Gentoo-Bug: 559636
X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=559636
---
[PATCH v2] fixes it to properly check the find_invalid_path_char return value
 bin/repoman | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/bin/repoman b/bin/repoman
index 1ba7841..2c42c2d 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -2570,7 +2570,11 @@ else:
 	if myunadded:
 		for x in range(len(myunadded)-1, -1, -1):
 			xs = myunadded[x].split("/")
-			if xs[-1] == "files":
+			if repo_config.find_invalid_path_char(myunadded[x]) != -1:
+				# The Manifest excludes this file,
+				# so it's safe to ignore.
+				del myunadded[x]
+			elif xs[-1] == "files":
 				print("!!! files dir is not added! Please correct this.")
 				sys.exit(-1)
 			elif xs[-1] == "Manifest":
-- 
2.4.6



  reply	other threads:[~2015-09-05 14:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-05 14:20 [gentoo-portage-dev] [PATCH] repoman: ignore unadded files when possible (bug 559636) Zac Medico
2015-09-05 14:31 ` Zac Medico [this message]
2015-09-05 16:16   ` [gentoo-portage-dev] [PATCH v2] " Brian Dolbec
2015-09-05 16:18     ` Zac Medico
2015-09-05 19:50       ` Zac Medico
2015-09-05 21:21         ` Brian Dolbec
2015-09-05 19:47     ` Mike Gilbert
2015-09-05 21:20       ` Brian Dolbec
2015-09-05 21:24       ` Brian Dolbec
2015-09-05 22:04         ` Brian Dolbec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441463487-4101-1-git-send-email-zmedico@gentoo.org \
    --to=zmedico@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox