* [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries
@ 2015-08-11 17:38 Michał Górny
2015-08-11 17:54 ` Zac Medico
0 siblings, 1 reply; 3+ messages in thread
From: Michał Górny @ 2015-08-11 17:38 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Michał Górny
Remove the code skipping EAPI=0 output in cache entries. There is really
no reason to treat EAPI=0 specially here, and this makes the output more
consistent.
---
bin/egencache | 2 --
1 file changed, 2 deletions(-)
diff --git a/bin/egencache b/bin/egencache
index 6075ccf..5c00248 100755
--- a/bin/egencache
+++ b/bin/egencache
@@ -297,8 +297,6 @@ class GenCache(object):
# EAPI from _parse_eapi_ebuild_head, we don't write cache
# entries for unsupported EAPIs.
if metadata is not None and eapi_supported:
- if metadata.get('EAPI') == '0':
- del metadata['EAPI']
for trg_cache in self._trg_caches:
self._write_cache(trg_cache,
cpv, repo_path, metadata, ebuild_hash)
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries
2015-08-11 17:38 [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries Michał Górny
@ 2015-08-11 17:54 ` Zac Medico
2015-08-11 19:53 ` Brian Dolbec
0 siblings, 1 reply; 3+ messages in thread
From: Zac Medico @ 2015-08-11 17:54 UTC (permalink / raw
To: gentoo-portage-dev
On 08/11/2015 10:38 AM, Michał Górny wrote:
> Remove the code skipping EAPI=0 output in cache entries. There is really
> no reason to treat EAPI=0 specially here, and this makes the output more
> consistent.
> ---
> bin/egencache | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/bin/egencache b/bin/egencache
> index 6075ccf..5c00248 100755
> --- a/bin/egencache
> +++ b/bin/egencache
> @@ -297,8 +297,6 @@ class GenCache(object):
> # EAPI from _parse_eapi_ebuild_head, we don't write cache
> # entries for unsupported EAPIs.
> if metadata is not None and eapi_supported:
> - if metadata.get('EAPI') == '0':
> - del metadata['EAPI']
> for trg_cache in self._trg_caches:
> self._write_cache(trg_cache,
> cpv, repo_path, metadata, ebuild_hash)
>
LTGM.
--
Thanks,
Zac
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries
2015-08-11 17:54 ` Zac Medico
@ 2015-08-11 19:53 ` Brian Dolbec
0 siblings, 0 replies; 3+ messages in thread
From: Brian Dolbec @ 2015-08-11 19:53 UTC (permalink / raw
To: gentoo-portage-dev
On Tue, 11 Aug 2015 10:54:10 -0700
Zac Medico <zmedico@gentoo.org> wrote:
> On 08/11/2015 10:38 AM, Michał Górny wrote:
> > Remove the code skipping EAPI=0 output in cache entries. There is
> > really no reason to treat EAPI=0 specially here, and this makes the
> > output more consistent.
> > ---
> > bin/egencache | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/bin/egencache b/bin/egencache
> > index 6075ccf..5c00248 100755
> > --- a/bin/egencache
> > +++ b/bin/egencache
> > @@ -297,8 +297,6 @@ class GenCache(object):
> > # EAPI from _parse_eapi_ebuild_head, we don't
> > write cache # entries for unsupported EAPIs.
> > if metadata is not None and eapi_supported:
> > - if metadata.get('EAPI') == '0':
> > - del metadata['EAPI']
> > for trg_cache in self._trg_caches:
> > self._write_cache(trg_cache,
> > cpv, repo_path, metadata,
> > ebuild_hash)
> >
>
> LTGM.
yeah, merge please
--
Brian Dolbec <dolsen>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-11 19:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-11 17:38 [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries Michał Górny
2015-08-11 17:54 ` Zac Medico
2015-08-11 19:53 ` Brian Dolbec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox