From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 5A4AB138A1A for ; Sat, 17 Jan 2015 13:16:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6CEB4E08FB; Sat, 17 Jan 2015 13:16:50 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0948DE08E0 for ; Sat, 17 Jan 2015 13:16:50 +0000 (UTC) Received: from pomiot.lan (mgorny-1-pt.tunnel.tserv28.waw1.ipv6.he.net [IPv6:2001:470:70:353::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 5D7A7340717; Sat, 17 Jan 2015 13:16:48 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-portage-dev@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-portage-dev] [PATCH] sync: fix module_names enumeration Date: Sat, 17 Jan 2015 14:16:43 +0100 Message-Id: <1421500603-15692-1-git-send-email-mgorny@gentoo.org> X-Mailer: git-send-email 2.2.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org X-Archives-Salt: fd702b3e-5605-4c15-934c-54ef329f2e61 X-Archives-Hash: 27aba903844f54f62a1b1ad5b877da02 Fix module_names enumeration to consider all modules. Before, the first module on the list was omitted ('cvs' in this case). Another thing is, the CVS module is completely, utterly and inevitably broken. And the whole syncing thing is a great pile of terribly mis-designed, unnecessarily complex code which can't work unless it is worked around like git module does... --- pym/portage/sync/controller.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pym/portage/sync/controller.py b/pym/portage/sync/controller.py index 9001298..3d217db 100644 --- a/pym/portage/sync/controller.py +++ b/pym/portage/sync/controller.py @@ -119,7 +119,7 @@ class SyncManager(object): self.callback = callback or self._sync_callback self.repo = repo self.exitcode = 1 - if repo.sync_type in self.module_names[1:]: + if repo.sync_type in self.module_names: tasks = [self.module_controller.get_class(repo.sync_type)] else: msg = "\n%s: Sync module '%s' is not an installed/known type'\n" \ -- 2.2.1