public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: [gentoo-portage-dev] [PATCH] Allow virtuals in package.provided
Date: Fri,  5 Dec 2014 17:43:14 +0100	[thread overview]
Message-ID: <1417797794-19449-1-git-send-email-mgorny@gentoo.org> (raw)

With new-style virtuals, there is no reason to enforce special rules to
virtuals in package.provided. If user wishes to implicitly provide
the virual package, we should not forbid him. Of course, he knows
the implications.
---
 man/portage.5                        | 7 -------
 pym/portage/package/ebuild/config.py | 6 ------
 2 files changed, 13 deletions(-)

diff --git a/man/portage.5 b/man/portage.5
index 150294b..46835b5 100644
--- a/man/portage.5
+++ b/man/portage.5
@@ -400,13 +400,6 @@ entries may cause installed packages satisfying equivalent dependencies
 to be removed by \fBemerge\fR(1) \fB\-\-depclean\fR actions (see the
 \fBACTIONS\fR section of the \fBemerge\fR(1) man page for more information).
 
-Virtual packages (virtual/*) should not be specified in package.provided,
-since virtual packages themselves do not provide any files, and
-package.provided is intended to represent packages that do provide files.
-Depending on the type of virtual, it may be necessary to add an entry to the
-virtuals file and/or add a package that satisfies a virtual to
-package.provided.
-
 .I Format:
 .nf
 \- comments begin with # (no inline comments)
diff --git a/pym/portage/package/ebuild/config.py b/pym/portage/package/ebuild/config.py
index 59e239b..4d1f1d5 100644
--- a/pym/portage/package/ebuild/config.py
+++ b/pym/portage/package/ebuild/config.py
@@ -803,12 +803,6 @@ class config(object):
 					has_invalid_data = True
 					del pkgprovidedlines[x]
 					continue
-				if cpvr[0] == "virtual":
-					writemsg(_("Virtual package in package.provided: %s\n") % \
-						myline, noiselevel=-1)
-					has_invalid_data = True
-					del pkgprovidedlines[x]
-					continue
 			if has_invalid_data:
 				writemsg(_("See portage(5) for correct package.provided usage.\n"),
 					noiselevel=-1)
-- 
2.2.0



             reply	other threads:[~2014-12-05 16:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 16:43 Michał Górny [this message]
2014-12-07  6:31 ` [gentoo-portage-dev] [PATCH] Allow virtuals in package.provided Zac Medico
2015-01-12  9:34   ` Michał Górny
2015-01-12 16:06     ` Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417797794-19449-1-git-send-email-mgorny@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox