From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 7C897138BA7 for ; Sun, 2 Nov 2014 19:18:36 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AC29BE08C7; Sun, 2 Nov 2014 19:18:30 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 37A9CE08C5 for ; Sun, 2 Nov 2014 19:18:30 +0000 (UTC) Received: from pomiot.lan (mgorny-1-pt.tunnel.tserv28.waw1.ipv6.he.net [IPv6:2001:470:70:353::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 6CDBF34033F; Sun, 2 Nov 2014 19:18:28 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-portage-dev@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-portage-dev] [PATCH 2/3] Update the QA checks to new eqatag API Date: Sun, 2 Nov 2014 20:18:19 +0100 Message-Id: <1414955900-32567-2-git-send-email-mgorny@gentoo.org> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1414955900-32567-1-git-send-email-mgorny@gentoo.org> References: <1414955900-32567-1-git-send-email-mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org X-Archives-Salt: 6e313721-8c05-43f6-9380-3c827a76cac2 X-Archives-Hash: b53888fcb8001ba8129ed89de3ebab54 --- bin/install-qa-check.d/05double-D | 8 ++++---- bin/install-qa-check.d/90world-writable | 4 +--- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/bin/install-qa-check.d/05double-D b/bin/install-qa-check.d/05double-D index 7d958f1..4b7737c 100644 --- a/bin/install-qa-check.d/05double-D +++ b/bin/install-qa-check.d/05double-D @@ -3,12 +3,12 @@ DD_check() { if [[ -d ${D%/}${D} ]] ; then eqawarn "QA Notice: files installed in \${D}/\${D}:" - local -i INSTALLTOD=0 + local files=() while read -r -d $'\0' i ; do - __eqawarnlog double-d "/${i##${D%/}${D}}" - ((INSTALLTOD++)) + files+=( "${i#${D%/}${D}}" ) done < <(find "${D%/}${D}" -print0) - die "Aborting due to QA concerns: ${INSTALLTOD} files installed in ${D%/}${D}" + eqatag -v double-D "${files[@]/#//}" + die "Aborting due to QA concerns: ${#files[@]} files installed in ${D%/}${D}" fi } diff --git a/bin/install-qa-check.d/90world-writable b/bin/install-qa-check.d/90world-writable index 490aaee..2b435ac 100644 --- a/bin/install-qa-check.d/90world-writable +++ b/bin/install-qa-check.d/90world-writable @@ -12,9 +12,7 @@ world_writable_check() { if [[ -n ${unsafe_files} ]] ; then eqawarn "QA Security Notice: world writable file(s):" - for x in $unsafe_files ; do - __eqawarnlog world-writable "$x" - done + eqatag -v world-writable $unsafe_files eqawarn "This may or may not be a security problem, most of the time it is one." eqawarn "Please double check that $PF really needs a world writeable bit and file bugs accordingly." -- 2.1.3