From: Michael Palimaka <kensington@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: Michael Palimaka <kensington@gentoo.org>
Subject: [gentoo-portage-dev] [PATCH 2/3] install-qa-check.d/05double-D: Write to log and improve consistency.
Date: Sun, 26 Oct 2014 03:16:00 +1100 [thread overview]
Message-ID: <1414253761-6310-2-git-send-email-kensington@gentoo.org> (raw)
In-Reply-To: <1414253761-6310-1-git-send-email-kensington@gentoo.org>
Present the list of offending files newline-delimitered for consistency
with other checks.
---
bin/install-qa-check.d/05double-D | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/bin/install-qa-check.d/05double-D b/bin/install-qa-check.d/05double-D
index 1634afd..84fcc89 100644
--- a/bin/install-qa-check.d/05double-D
+++ b/bin/install-qa-check.d/05double-D
@@ -2,9 +2,10 @@
DD_check() {
if [[ -d ${D%/}${D} ]] ; then
+ eqawarn "QA Notice: files installed in \${D}/\${D}:"
local -i INSTALLTOD=0
while read -r -d $'\0' i ; do
- eqawarn "QA Notice: /${i##${D%/}${D}} installed in \${D}/\${D}"
+ eqawarnlog double-d "/${i##${D%/}${D}}"
((INSTALLTOD++))
done < <(find "${D%/}${D}" -print0)
die "Aborting due to QA concerns: ${INSTALLTOD} files installed in ${D%/}${D}"
--
2.0.4
next prev parent reply other threads:[~2014-10-25 16:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 16:15 [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions Michael Palimaka
2014-10-25 16:16 ` Michael Palimaka [this message]
2014-10-26 15:14 ` [gentoo-portage-dev] [PATCH 2/3] install-qa-check.d/05double-D: Write to log and improve consistency Michael Palimaka
2014-10-25 16:16 ` [gentoo-portage-dev] [PATCH 3/3] install-qa-check.d/90world-writable: Write log and general cleanup Michael Palimaka
2014-10-26 15:16 ` Michael Palimaka
2014-10-25 19:42 ` [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions Zac Medico
2014-10-25 20:25 ` Michał Górny
2014-10-25 20:28 ` Zac Medico
2014-10-25 20:41 ` Michał Górny
2014-10-25 20:53 ` Zac Medico
2014-10-25 19:53 ` Zac Medico
2014-10-25 19:54 ` Zac Medico
2014-10-25 20:00 ` Zac Medico
2014-10-25 20:13 ` [gentoo-portage-dev] " Michael Palimaka
2014-10-25 20:15 ` Zac Medico
2014-10-25 20:26 ` [gentoo-portage-dev] " Michał Górny
2014-10-25 20:32 ` Zac Medico
2014-10-25 20:57 ` Zac Medico
2014-10-26 19:31 ` [gentoo-portage-dev] " Michael Palimaka
2014-10-26 20:05 ` Zac Medico
2014-10-27 13:15 ` Michael Palimaka
2014-10-27 19:33 ` Zac Medico
2014-10-26 15:12 ` [gentoo-portage-dev] [PATCH 1/3] " Michael Palimaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414253761-6310-2-git-send-email-kensington@gentoo.org \
--to=kensington@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox