From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C5B9B13877A for ; Tue, 12 Aug 2014 09:37:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 83977E0CA2; Tue, 12 Aug 2014 09:37:24 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EA679E0CA1 for ; Tue, 12 Aug 2014 09:37:23 +0000 (UTC) Received: from hackintosh.cerpus.lan (213.167.121.42.static.lyse.net [213.167.121.42]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bernalex) by smtp.gentoo.org (Postfix) with ESMTPSA id 3EBF13404DF; Tue, 12 Aug 2014 09:37:22 +0000 (UTC) From: Alexander Berntsen To: gentoo-portage-dev@lists.gentoo.org Cc: Alexander Berntsen Subject: [gentoo-portage-dev] [PATCH 1/4] emerge: Deprecate --autounmask Date: Tue, 12 Aug 2014 11:37:12 +0200 Message-Id: <1407836235-13528-2-git-send-email-bernalex@gentoo.org> X-Mailer: git-send-email 1.8.5.5 In-Reply-To: <1407836235-13528-1-git-send-email-bernalex@gentoo.org> References: <1407836235-13528-1-git-send-email-bernalex@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org X-Archives-Salt: 95a713b5-c113-4d4c-9aef-71a39aaf854b X-Archives-Hash: ac97f1fb99c28808df50d64b37edff41 From: Alexander Berntsen Remove the --autounmask option from emerge. Please note that removing the option does not mean that the variable used for keeping track of autounmasking is removed from depgraph.py. Signed-off-by: Alexander Berntsen --- man/emerge.1 | 33 ++++++++++----------------------- pym/_emerge/depgraph.py | 3 +-- pym/_emerge/main.py | 9 --------- 3 files changed, 11 insertions(+), 34 deletions(-) diff --git a/man/emerge.1 b/man/emerge.1 index e32bb43..d0a0806 100644 --- a/man/emerge.1 +++ b/man/emerge.1 @@ -336,38 +336,25 @@ invalid input. This helps prevent accidental acceptance of the first choice. This option is intended to be set in the \fBmake.conf\fR(5) \fBEMERGE_DEFAULT_OPTS\fR variable. -.TP -.BR "\-\-autounmask [ y | n ]" -Automatically unmask packages and generate package.use -settings as necessary to satisfy dependencies. This -option is enabled by default. If any configuration -changes are required, then they will be displayed -after the merge list and emerge will immediately -abort. If the displayed configuration changes are -satisfactory, you should copy and paste them into -the specified configuration file(s), or enable the \fB\-\-autounmask\-write\fR option. The \fBEMERGE_DEFAULT_OPTS\fR variable may be used to disable this option by default in \fBmake.conf\fR(5). .TP .BR "\-\-autounmask\-unrestricted\-atoms [ y | n ]" -If \-\-autounmask is enabled, keyword and mask changes -using the \'=\' operator will be written. With this -option, \'>=\' operators will be used whenever possible. -USE and license changes always use the latter behavior. +Keyword and mask changes using the \'=\' operator will be written. With this +option, \'>=\' operators will be used whenever possible. USE and license +changes always use the latter behavior. .TP .BR "\-\-autounmask\-keep\-masks [ y | n ]" -If \-\-autounmask is enabled, no package.unmask or ** keyword changes -will be created. This leads to unsatisfied dependencies if -no other solution exists. +No package.unmask or ** keyword changes will be created if this is activated. +This leads to unsatisfied dependencies if no other solution exists. .TP .BR "\-\-autounmask\-write [ y | n ]" -If \-\-autounmask is enabled, changes are written -to config files, respecting \fBCONFIG_PROTECT\fR and \fB\-\-ask\fR. -If the corresponding package.* is a file, the changes are appended to -it, if it is a directory, changes are written to the lexicographically -last file. This way it is always ensured that the new changes take -precedence over existing changes. +Write required unmask changes to the relevant config files, respecting +\fBCONFIG_PROTECT\fR and \fB\-\-ask\fR. If the corresponding package.* is a +file, the changes are appended to it, if it is a directory, changes are written +to the lexicographically last file. This way it is always ensured that the new +changes take precedence over existing changes. .TP .BR \-\-backtrack=COUNT Specifies an integer number of times to backtrack if diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py index a10297a..b0cfc92 100644 --- a/pym/_emerge/depgraph.py +++ b/pym/_emerge/depgraph.py @@ -418,7 +418,7 @@ class _dynamic_depgraph_config(object): self._backtrack_infos = {} self._buildpkgonly_deps_unsatisfied = False - self._autounmask = depgraph._frozen_config.myopts.get('--autounmask') != 'n' + self._autounmask = True self._success_without_autounmask = False self._traverse_ignored_deps = False self._complete_mode = False @@ -8502,7 +8502,6 @@ def _backtrack_depgraph(settings, trees, myopts, myparams, myaction, myfiles, sp "\n\nautounmask breakage detected\n\n", noiselevel=-1, level=logging.DEBUG) mydepgraph.display_problems() - myopts["--autounmask"] = "n" mydepgraph = depgraph(settings, trees, myopts, myparams, spinner, frozen_config=frozen_config, allow_backtracking=False) success, favorites = mydepgraph.select_files(myfiles) diff --git a/pym/_emerge/main.py b/pym/_emerge/main.py index 52aa9c5..86c0c62 100644 --- a/pym/_emerge/main.py +++ b/pym/_emerge/main.py @@ -126,7 +126,6 @@ def insert_optional_args(args): default_arg_opts = { '--alert' : y_or_n, '--ask' : y_or_n, - '--autounmask' : y_or_n, '--autounmask-keep-masks': y_or_n, '--autounmask-unrestricted-atoms' : y_or_n, '--autounmask-write' : y_or_n, @@ -314,11 +313,6 @@ def parse_opts(tmpcmdline, silent=False): "choices" : true_y_or_n }, - "--autounmask": { - "help" : "automatically unmask packages", - "choices" : true_y_or_n - }, - "--autounmask-unrestricted-atoms": { "help" : "write autounmask changes with >= atoms if possible", "choices" : true_y_or_n @@ -693,9 +687,6 @@ def parse_opts(tmpcmdline, silent=False): else: myoptions.ask = None - if myoptions.autounmask in true_y: - myoptions.autounmask = True - if myoptions.autounmask_unrestricted_atoms in true_y: myoptions.autounmask_unrestricted_atoms = True -- 1.8.5.5