From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E76DA138247 for ; Thu, 16 Jan 2014 00:08:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A5A82E09B6; Thu, 16 Jan 2014 00:08:28 +0000 (UTC) Received: from michel.telenet-ops.be (michel.telenet-ops.be [195.130.137.88]) by pigeon.gentoo.org (Postfix) with ESMTP id 7665EE098A for ; Thu, 16 Jan 2014 00:08:27 +0000 (UTC) Received: from localhost.localdomain ([94.226.55.127]) by michel.telenet-ops.be with bizsmtp id EQ8S1n02b2khLEN06Q8SYM; Thu, 16 Jan 2014 01:08:26 +0100 From: Tom Wijsman To: gentoo-portage-dev@lists.gentoo.org Subject: [gentoo-portage-dev] Repoman patches for bugs #205909, #245305 and #482084. Date: Thu, 16 Jan 2014 01:07:17 +0100 Message-Id: <1389830840-25848-1-git-send-email-tomwij@gentoo.org> X-Mailer: git-send-email 1.8.5.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org X-Archives-Salt: fd5b4def-ae13-4733-a51b-72cd4a4af736 X-Archives-Hash: e3edcfd02731143db7f9bfef806dce70 In reply, you will find three repoman patches; PATCH 1 is a bit more complex which I will detail here, the other two patches should be fairly trivial. In the first patch I need to use the @system set, as I only want to check DEPEND for packages not in the @system set; thus here is kept in mind that the @system set could possible change, in which case the check continues to work. After checking up with Arfrever, a first version that I came up with is > +from portage._sets.profiles import PackagesSystemSet > +system_set_atoms = PackagesSystemSet(portage.settings.profiles).getAtoms() but I am not sure if this is appropriate when used in other repositories. Arfrever warned me about this but I think I do not fully understand that. Both archive_formats* variables are based on the PMS specifications. The rest of the code has comments and should be trivial to understand. For the check name we came up with "unpack.DEPEND.missing"; most of the checks are two words, so, I don't know if three words is permitted. At least repoman runs without complaining or bailing out because of this. There's still a TODO left in the code that leaves me in doubt on how to properly ask the keywords to Portage; seems that I still need to learn to find my way through the documentation, but I guess after getting pointed to it a few times it will become easier. These are my first patches to the Repoman code, all three patches introduce a new warning / error, therefore it might be possible that I missed something. Grepping on an existing warning I saw the man page needs to be updated; since I never did that before, feel free to check if the syntax of that is right. Thank you for taking your time to review these. -- bin/repoman | 63 ++++++++++++++++++++++++++++++++++++++++++++++++ +++++++++++++++ man/repoman.1 | 10 ++++++++++ pym/repoman/checks.py | 10 ++++++++++ 3 files changed, 83 insertions(+) [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909). [PATCH 2/3] Have repoman check that a package directory contains at least one ebuild (bug #245305). [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084). -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : TomWij@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D