From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 0022A138247 for ; Sat, 11 Jan 2014 05:13:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 791ADE0A0B; Sat, 11 Jan 2014 05:13:04 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BF14AE0A02 for ; Sat, 11 Jan 2014 05:13:02 +0000 (UTC) Received: from [192.168.1.210] (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id A71BA33F715 for ; Sat, 11 Jan 2014 05:13:01 +0000 (UTC) Message-ID: <1389416943.7103.136.camel@big_daddy.dol-sen.ca> Subject: Re: [gentoo-portage-dev] [PATCH] Check for and report read-only filesystems From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Date: Fri, 10 Jan 2014 21:09:03 -0800 In-Reply-To: <52D0B588.4010506@gentoo.org> References: <52D0B588.4010506@gentoo.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-nWrjzWNXKe7sekhDCVxN" X-Mailer: Evolution 3.6.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 2e98305b-a2bb-40dd-bc8e-1873193fe5c3 X-Archives-Hash: 3e18765a7f52723b1693bab9bc0d25a0 --=-nWrjzWNXKe7sekhDCVxN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2014-01-10 at 22:07 -0500, Chris Reffett wrote: > Hi all, > Attached is a patch to test if Portage is going to write to a > read-only filesystem and print out the list of filesystems that need > to be remounted RW. This leaves ${D} intact rather than having some > files moved before hitting the RO filesystem. Fixes bug 378869. Since > git.overlays.gentoo.org is down, I haven't had the chance to rebase > this against latest, but I can resubmit if it doesn't cleanly apply. > This is my first patch to the list, so I apologize if I didn't submit > correctly. >=20 > Chris Reffett yeah, patch looks good. Only thing I didn't like is the return 1 IS that suppose to be True or sys.exit() value? If that is what the module was using, then it's ok. Personally I'm not a fan of using 0, 1 for False, True. But that will come later... --=-nWrjzWNXKe7sekhDCVxN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAABCgBmBQJS0NHvXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfL3O4H/jPBDjNW5OWVIBjyitcfsg9u S6dMRacmhFWl2NOzbIwbgjjqZxu7Q2Du4SEH8sG2+itxqLkYZzwlorLn0Dl35bcN 3kfeQ6xK3bApARASosb6SFjmBFkAjFpaiIv51Y9HqDusomi11UL1UxJHQIuIw2Fl 7xJvUCnY/d18MM0s6TRoVUIuu0IfF3GAewJrnAbh1rkFzgUZPKlmSZA8KmYn5rIX 4l271aaFrAmQpPQMsMRg0tVwG/43dGw2q4HHMQgTNDe8wJSFOhVw77z4jzs8+zsK WEl3qGAOnH6AM7eiRfZyC7PUpAgIrluq0RRydRd33ED6Um5r2kqBQJp4GsJ5AAo= =FB96 -----END PGP SIGNATURE----- --=-nWrjzWNXKe7sekhDCVxN--