From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] Check for and report read-only filesystems
Date: Fri, 10 Jan 2014 21:09:03 -0800 [thread overview]
Message-ID: <1389416943.7103.136.camel@big_daddy.dol-sen.ca> (raw)
In-Reply-To: <52D0B588.4010506@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On Fri, 2014-01-10 at 22:07 -0500, Chris Reffett wrote:
> Hi all,
> Attached is a patch to test if Portage is going to write to a
> read-only filesystem and print out the list of filesystems that need
> to be remounted RW. This leaves ${D} intact rather than having some
> files moved before hitting the RO filesystem. Fixes bug 378869. Since
> git.overlays.gentoo.org is down, I haven't had the chance to rebase
> this against latest, but I can resubmit if it doesn't cleanly apply.
> This is my first patch to the list, so I apologize if I didn't submit
> correctly.
>
> Chris Reffett
yeah, patch looks good.
Only thing I didn't like is the return 1 IS that suppose to be True or
sys.exit() value?
If that is what the module was using, then it's ok. Personally I'm not
a fan of using 0, 1 for False, True.
But that will come later...
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2014-01-11 5:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 3:07 [gentoo-portage-dev] [PATCH] Check for and report read-only filesystems Chris Reffett
2014-01-11 5:09 ` Brian Dolbec [this message]
2014-01-11 14:22 ` Chris Reffett
2014-01-13 23:24 ` Mike Frysinger
2014-01-17 0:39 ` [gentoo-portage-dev] [PATCH v2] Test for read-only filesystems, bail out during preinst if there are any which will be written to and display a useful error message. Fixes bug 378869 Chris Reffett
2014-01-19 2:00 ` [gentoo-portage-dev] [PATCH v3] " Chris Reffett
2014-01-19 9:17 ` Mike Frysinger
2014-01-19 10:39 ` Alexander Berntsen
2014-01-19 21:43 ` Alec Warner
2014-01-21 3:28 ` Mike Frysinger
2014-01-21 3:53 ` Gordon Pettey
2014-01-21 22:44 ` Mike Frysinger
2014-01-21 0:50 ` [gentoo-portage-dev] [PATCH v4] " Chris Reffett
2014-01-21 3:32 ` Mike Frysinger
2014-01-21 4:00 ` [gentoo-portage-dev] [PATCH v5] " Chris Reffett
2014-01-22 5:24 ` Mike Frysinger
2014-01-22 18:33 ` [gentoo-portage-dev] [PATCH v6] " Chris Reffett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389416943.7103.136.camel@big_daddy.dol-sen.ca \
--to=dolsen@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox