From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NLEMr-0006f1-7B for garchives@archives.gentoo.org; Thu, 17 Dec 2009 11:18:11 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 701FEE092F; Thu, 17 Dec 2009 11:17:20 +0000 (UTC) Received: from homeless.linbsd.net (homeless.linbsd.net [64.127.112.66]) by pigeon.gentoo.org (Postfix) with ESMTP id 52E16E092F for ; Thu, 17 Dec 2009 11:17:20 +0000 (UTC) Received: from [192.168.1.2] (dsl092-011-131.sfo1.dsl.speakeasy.net [66.92.11.131]) by homeless.linbsd.net (Postfix) with ESMTPA id EA94857896; Thu, 17 Dec 2009 03:17:19 -0800 (PST) Subject: Re: [gentoo-portage-dev] ia64 rpaths and python building... From: Ned Ludd To: gentoo-portage-dev@lists.gentoo.org Cc: Markus Duft In-Reply-To: <200912170521.26384.vapier@gentoo.org> References: <4B29FC1C.20907@gentoo.org> <200912170521.26384.vapier@gentoo.org> Content-Type: text/plain Date: Thu, 17 Dec 2009 03:17:19 -0800 Message-Id: <1261048639.5675.5.camel@localhost> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-Archives-Salt: a0fd56d6-d6a0-4da1-a6b5-ca08c5b33e60 X-Archives-Hash: 7e67f2aa63940a1361e99d469d94dacb On Thu, 2009-12-17 at 05:21 -0500, Mike Frysinger wrote: > On Thursday 17 December 2009 04:38:36 Markus Duft wrote: > > I recently did some ia64-hpux hacking in prefix, and i stumbled over > > alittle problem: > > > > the native linker collects -L options on the command line, and python > > uses -L. while building. this results in . beeing in rpath. > > > > now when $PWD == $S, there is libpython-*.so, and executing the already > > installed python finds (through rpath ".") this local libpython. this > > (although binary exactly the same) refuses to load installed extensions > > (Fatal Python Error: ....). > > > > The problem was caused by the filter-bash-environment.py call in > > ebuild.sh, _only_ during the "test" phase seemingly. > > > > the attached patch fixes the problem for me - what do you think? I guess > > there are better ways to tackle the problem, but i needed to get this to > > work ;) > > this ignores the real problem. there should never be an installed binary > whose rpath includes $PWD. this is a terrible security issues waiting to bite > you in the ass, or cause random failures depending on what the user's cwd is > at any point in time. > > the second change (adding the || exit) is a good idea in theory, but the > proposed change is incorrect. use the assert helper so that the exit values > of all commands in the pipeline are checked. > -mike Yep to everything Mike said..