Re: [gentoo-portage-dev] ia64 rpaths and python building...

[Ned Ludd <solar@gentoo.org>]

On Thu, 2009-12-17 at 05:21 -0500, Mike Frysinger wrote:
> On Thursday 17 December 2009 04:38:36 Markus Duft wrote:
> > I recently did some ia64-hpux hacking in prefix, and i stumbled over
> > alittle problem:
> > 
> > the native linker collects -L options on the command line, and python
> > uses -L. while building. this results in . beeing in rpath.
> > 
> > now when $PWD == $S, there is libpython-*.so, and executing the already
> > installed python finds (through rpath ".") this local libpython. this
> > (although binary exactly the same) refuses to load installed extensions
> > (Fatal Python Error: ....).
> > 
> > The problem was caused by the filter-bash-environment.py call in
> > ebuild.sh, _only_ during the "test" phase seemingly.
> > 
> > the attached patch fixes the problem for me - what do you think? I guess
> > there are better ways to tackle the problem, but i needed to get this to
> > work ;)
> 
> this ignores the real problem.  there should never be an installed binary 
> whose rpath includes $PWD.  this is a terrible security issues waiting to bite 
> you in the ass, or cause random failures depending on what the user's cwd is 
> at any point in time.
> 
> the second change (adding the || exit) is a good idea in theory, but the 
> proposed change is incorrect.  use the assert helper so that the exit values 
> of all commands in the pipeline are checked.
> -mike

Yep to everything Mike said..