From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org)
by nuthatch.gentoo.org with esmtp (Exim 4.43)
id 1E9P9J-0006Ck-Dc
for garchives@archives.gentoo.org; Sun, 28 Aug 2005 15:32:45 +0000
Received: from robin.gentoo.org (localhost [127.0.0.1])
by robin.gentoo.org (8.13.4/8.13.4) with SMTP id j7SFUQQ0002668;
Sun, 28 Aug 2005 15:30:26 GMT
Received: from egr.msu.edu (jeeves.egr.msu.edu [35.9.37.127])
by robin.gentoo.org (8.13.4/8.13.4) with ESMTP id j7SFUN4N030677
for <gentoo-portage-dev@lists.gentoo.org>; Sun, 28 Aug 2005 15:30:24 GMT
Received: from www.egr.msu.edu (merovingian [35.9.37.132])
by egr.msu.edu (8.13.4/8.13.4) with ESMTP id j7SFW80G007370
for <gentoo-portage-dev@lists.gentoo.org>; Sun, 28 Aug 2005 11:32:08 -0400 (EDT)
Received: from (SquirrelMail authenticated user warnera6)
by www.egr.msu.edu with HTTP;
Sun, 28 Aug 2005 11:32:10 -0400 (EDT)
Message-ID: <1125243130.warnera6.squirrel@localhost>
In-Reply-To: <20050828092856.GA17538@nightcrawler>
References: <20050827105357.GY1701@nightcrawler>
<200508281446.34126.jstubbs@gentoo.org>
<20050828092856.GA17538@nightcrawler>
Date: Sun, 28 Aug 2005 11:32:10 -0400 (EDT)
Subject: Re: [gentoo-portage-dev] PATCH: initial EAPI awareness
From: warnera6@egr.msu.edu
To: gentoo-portage-dev@lists.gentoo.org
User-Agent: SquirrelMail/1.4.4
Precedence: bulk
List-Post: <mailto:gentoo-portage-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-portage-dev+help@gentoo.org>
List-Unsubscribe: <mailto:gentoo-portage-dev+unsubscribe@gentoo.org>
List-Subscribe: <mailto:gentoo-portage-dev+subscribe@gentoo.org>
List-Id: Gentoo Linux mail <gentoo-portage-dev.gentoo.org>
X-BeenThere: gentoo-portage-dev@gentoo.org
Reply-to: gentoo-portage-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
Importance: Normal
X-Archives-Salt: 5593e3a2-de1d-4be1-a5fd-affbc57345c6
X-Archives-Hash: 944805b966511b20743b9110e30a6938
> On Sun, Aug 28, 2005 at 02:46:28PM +0900, Jason Stubbs wrote:
>> On Saturday 27 August 2005 19:53, Brian Harring wrote:
>> > Please test this out; if you want to test the EAPI checking, tag
>> > EAPI=1 into an ebuild, and try making emerge bail.
>>
>> + print "EAPI check, unknown source "+str(x[0])+" for "+x[2]+", this
>> shouldn't occur",mylist
>> + sys.exit(1)
>>
>> These two are in the patch. Can that be made an exception please? That
>> way
>> --debug could still be useful if the bug hits.
> That's debugging; not knowing (due to design flaws) all potentials for
> x[0], stuck that in debugging for anyone running the patch; people
> hitting it reporting back (hopefully), for debugging
>
> Final version won't include it.
> ~harring
>
pppfft, you were just complaining about all the sys.exit()'s in the code
and then you go and add one yourself. raise something instead, even if
it's just an Exception, that way it saves anyone from grepping through the
code for the error message.
-Alec
PS: Squirrelmail sucks for actual work :P
--
gentoo-portage-dev@gentoo.org mailing list