* [gentoo-portage-dev] [PATCH] repoman: add 'user.eclass' to deprecated eclasses
@ 2019-07-23 15:00 Michał Górny
2019-07-23 20:05 ` Zac Medico
2019-07-24 6:19 ` Ulrich Mueller
0 siblings, 2 replies; 6+ messages in thread
From: Michał Górny @ 2019-07-23 15:00 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Michał Górny
Make repoman report user.eclass as deprecated by GLEP 81.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
repoman/lib/repoman/modules/linechecks/deprecated/inherit.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py b/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
index 77ad4f625..361da09b9 100644
--- a/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
+++ b/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
@@ -30,6 +30,7 @@ class InheritDeprecated(LineCheck):
"mono": "mono-env",
"python": "python-r1 / python-single-r1 / python-any-r1",
"ruby": "ruby-ng",
+ "user": "GLEP 81",
"versionator": "eapi7-ver (built-in since EAPI 7)",
"x-modular": "xorg-2",
}
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] repoman: add 'user.eclass' to deprecated eclasses
2019-07-23 15:00 [gentoo-portage-dev] [PATCH] repoman: add 'user.eclass' to deprecated eclasses Michał Górny
@ 2019-07-23 20:05 ` Zac Medico
2019-07-24 2:23 ` Michał Górny
2019-07-24 6:19 ` Ulrich Mueller
1 sibling, 1 reply; 6+ messages in thread
From: Zac Medico @ 2019-07-23 20:05 UTC (permalink / raw
To: gentoo-portage-dev, Michał Górny
[-- Attachment #1.1: Type: text/plain, Size: 940 bytes --]
On 7/23/19 8:00 AM, Michał Górny wrote:
> Make repoman report user.eclass as deprecated by GLEP 81.
>
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
> repoman/lib/repoman/modules/linechecks/deprecated/inherit.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py b/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
> index 77ad4f625..361da09b9 100644
> --- a/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
> +++ b/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
> @@ -30,6 +30,7 @@ class InheritDeprecated(LineCheck):
> "mono": "mono-env",
> "python": "python-r1 / python-single-r1 / python-any-r1",
> "ruby": "ruby-ng",
> + "user": "GLEP 81",
> "versionator": "eapi7-ver (built-in since EAPI 7)",
> "x-modular": "xorg-2",
> }
>
Looks good, please merge.
--
Thanks,
Zac
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] repoman: add 'user.eclass' to deprecated eclasses
2019-07-23 20:05 ` Zac Medico
@ 2019-07-24 2:23 ` Michał Górny
0 siblings, 0 replies; 6+ messages in thread
From: Michał Górny @ 2019-07-24 2:23 UTC (permalink / raw
To: gentoo-portage-dev
[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]
On Tue, 2019-07-23 at 13:05 -0700, Zac Medico wrote:
> On 7/23/19 8:00 AM, Michał Górny wrote:
> > Make repoman report user.eclass as deprecated by GLEP 81.
> >
> > Signed-off-by: Michał Górny <mgorny@gentoo.org>
> > ---
> > repoman/lib/repoman/modules/linechecks/deprecated/inherit.py | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py b/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
> > index 77ad4f625..361da09b9 100644
> > --- a/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
> > +++ b/repoman/lib/repoman/modules/linechecks/deprecated/inherit.py
> > @@ -30,6 +30,7 @@ class InheritDeprecated(LineCheck):
> > "mono": "mono-env",
> > "python": "python-r1 / python-single-r1 / python-any-r1",
> > "ruby": "ruby-ng",
> > + "user": "GLEP 81",
> > "versionator": "eapi7-ver (built-in since EAPI 7)",
> > "x-modular": "xorg-2",
> > }
> >
>
> Looks good, please merge.
Merged, thanks.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] repoman: add 'user.eclass' to deprecated eclasses
2019-07-23 15:00 [gentoo-portage-dev] [PATCH] repoman: add 'user.eclass' to deprecated eclasses Michał Górny
2019-07-23 20:05 ` Zac Medico
@ 2019-07-24 6:19 ` Ulrich Mueller
2019-07-24 8:16 ` Michał Górny
1 sibling, 1 reply; 6+ messages in thread
From: Ulrich Mueller @ 2019-07-24 6:19 UTC (permalink / raw
To: Michał Górny; +Cc: gentoo-portage-dev
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
>>>>> On Tue, 23 Jul 2019, Michał Górny wrote:
> Make repoman report user.eclass as deprecated by GLEP 81.
I don't understand. user.eclass is inherited by both acct-user.eclass
and acct-group.eclass, therefore in active use.
Or are you planning to inline its code in the inheriting eclasses?
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] repoman: add 'user.eclass' to deprecated eclasses
2019-07-24 6:19 ` Ulrich Mueller
@ 2019-07-24 8:16 ` Michał Górny
2019-07-24 17:42 ` Zac Medico
0 siblings, 1 reply; 6+ messages in thread
From: Michał Górny @ 2019-07-24 8:16 UTC (permalink / raw
To: gentoo-portage-dev, Ulrich Mueller
Dnia July 24, 2019 6:19:05 AM UTC, Ulrich Mueller <ulm@gentoo.org> napisał(a):
>>>>>> On Tue, 23 Jul 2019, Michał Górny wrote:
>
>> Make repoman report user.eclass as deprecated by GLEP 81.
>
>I don't understand. user.eclass is inherited by both acct-user.eclass
>and acct-group.eclass, therefore in active use.
>
>Or are you planning to inline its code in the inheriting eclasses?
This doesn't trigger for indirect inherits. Unless I tested wrong.
>
>Ulrich
--
Best regards,
Michał Górny
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] repoman: add 'user.eclass' to deprecated eclasses
2019-07-24 8:16 ` Michał Górny
@ 2019-07-24 17:42 ` Zac Medico
0 siblings, 0 replies; 6+ messages in thread
From: Zac Medico @ 2019-07-24 17:42 UTC (permalink / raw
To: gentoo-portage-dev, Michał Górny, Ulrich Mueller
[-- Attachment #1.1: Type: text/plain, Size: 623 bytes --]
On 7/24/19 1:16 AM, Michał Górny wrote:
> Dnia July 24, 2019 6:19:05 AM UTC, Ulrich Mueller <ulm@gentoo.org> napisał(a):
>>>>>>> On Tue, 23 Jul 2019, Michał Górny wrote:
>>
>>> Make repoman report user.eclass as deprecated by GLEP 81.
>>
>> I don't understand. user.eclass is inherited by both acct-user.eclass
>> and acct-group.eclass, therefore in active use.
>>
>> Or are you planning to inline its code in the inheriting eclasses?
>
> This doesn't trigger for indirect inherits. Unless I tested wrong.
Correct. This checks direct inherits that are parsed from the ebuild file.
--
Thanks,
Zac
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-24 17:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-23 15:00 [gentoo-portage-dev] [PATCH] repoman: add 'user.eclass' to deprecated eclasses Michał Górny
2019-07-23 20:05 ` Zac Medico
2019-07-24 2:23 ` Michał Górny
2019-07-24 6:19 ` Ulrich Mueller
2019-07-24 8:16 ` Michał Górny
2019-07-24 17:42 ` Zac Medico
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox